Failed message notification not visible when viewing another space

[kittykat]

Steps to reproduce

1. Send message while the network is dropping out
2. Navigate to a different space
   -> Message fails to send
   -> User is not notified of failure while under the assumption that it has sent
   -> Message is not sent automatically when network becomes available again

What happened?

The failure notification takes a while to appear, giving the user a sense that the message sent before the network dropped out and the notification is not visible from another space. So if the user navigates away from the space, then they may not find out about the failed message until a long time later.

What did you expect?

Something like this:

There is prior art for overlaying notifications on avatars:

URL for webapp

develop.element.io

Development checklist

• Tagged as T-Defect, and with correct A-, S- and O-* labels
• Can be reproduced from steps (see above)
• Developer has acquired all needed info from issue author and issue is not labelled with X-Needs-Info
• Design team has signed off on the feature: final design has been approved by the Element design team and attached to this issue:
• Acceptance criteria (in scope) have been clearly defined:
  • Failure warning is visible for recent conversations when viewing another space
• Out of scope:
  • …

[novocaine]

Note that we do (eventually) show a badge next to the room

But there is no badge on the space showing it has unsent messages

[niquewoodhouse]

I don't know the sizing of the ! or the notification dots, so sizing of things should be ignored...but used the same logic as the room error and notification badges in Element:

• Tapping the dot on a Space takes you to the relevant room (as in Spaces panel)
• The ! is considered more important than the general notification dots (as in room list).

ele-web-spaces-error-sending-01.mp4

Figma

[t3chguy]

So one minor issue I have with this from a data hierarchy PoV is that it seems weird that we aggregate ! to a count on the room sublist but then back to a ! on the space panel - definitely doable just feels strange