Selecting a room from room list search should not jump to a space

[jryans]

Steps to reproduce

1. Enable "Show all rooms in Home" in Preferences
2. From the Home space, search for some room joined to a space, such as "Matrix HQ"
3. Click on the "Matrix HQ" room tile

What happened?

What did you expect?

I expect to remain in the Home space, since that is where I started.

What happened?

My view changed to the "Matrix Community" space, I assume since HQ is part of that.

Operating system

macOS

Browser information

Firefox 94

URL for webapp

develop.element.io

Homeserver

matrix.org

Have you submitted a rageshake?

No

[jryans]

AFAICT, this is a regression in the last week or so, as it was working the way I expected for most of the Spaces beta period on develop.

[t3chguy]

Weirdly I cannot reproduce this.

Screen.Recording.2021-09-29.at.14.33.04.mov

[jryans]

Hmm, that's quite puzzling... here's a recording from my side:

Screen.Recording.2021-09-29.at.14.36.51.mov

[jryans]

Hmm, curious, it seems like SpaceStore does not believe it is in "all rooms in Home" mode, even though the setting is enabled... 🤔

[jryans]

mxSettingsStore.getValue("Spaces.allRoomsInHome") says true

[t3chguy]

So is mxSpaceStore.allRoomsInHome false then?

[jryans]

So is mxSpaceStore.allRoomsInHome false then?

Yes, indeed, it gives false. 🤔

[t3chguy]

oh.
I know what it is, and it is indeed a recent regression from me adding a null-guard to the dispatch handler, so it misses the setting being read

[t3chguy]

Thanks for the debugging @jryans

[jryans]

Verified fixed on develop, thanks! 😄