Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Threads as Beta #21351

Closed
novocaine opened this issue Mar 8, 2022 · 9 comments · Fixed by matrix-org/matrix-react-sdk#8081
Closed

Label Threads as Beta #21351

novocaine opened this issue Mar 8, 2022 · 9 comments · Fixed by matrix-org/matrix-react-sdk#8081

Comments

@novocaine
Copy link
Contributor

novocaine commented Mar 8, 2022

When we release threads to the public, we initially need them to be labelled as beta. We'd like to start gathering feedback and finding bugs from the public, but threads will be missing some features around notifications, so it's helpful to flag that the feature isn't quite done yet.

We will remove this label once we have launched Threads P1.

For web, this should include taking threads out of labs and making it available as a regular setting for all users.

@janogarcia
Copy link

@novocaine I'm attaching the mockups and reassigning it to @gsouquet.

Source
Threads — Beta feedback

Snapshot

Threads – Figma

@janogarcia janogarcia assigned germain-gg and unassigned janogarcia Mar 15, 2022
@germain-gg
Copy link
Contributor

Duplicate of #21351

@germain-gg germain-gg marked this as a duplicate of #21351 Mar 15, 2022
@germain-gg germain-gg reopened this Mar 15, 2022
@germain-gg
Copy link
Contributor

@janogarcia beta features also require some copy on the "settings" tab, alongside some little imagery that explain what the feature is.
If we decide that we can't opt-out, then I will add an option to hide the button.

Screen Shot 2022-03-16 at 09 32 20

Would you be able to share copy + imagery for threads here?

@janogarcia
Copy link

janogarcia commented Mar 17, 2022

@gsouquet Updated the Figma mockups to include the card for Labs.

Snapshot

Threads beta card (2)

@t3chguy
Copy link
Member

t3chguy commented Mar 29, 2022

@janogarcia in my opinion users should not be forced into a Beta, psychologically that has bad connotations of degrading a product. If a user wants to opt out of this beta they would have to roll back to an older version and miss out of security updates (given we do not backport them).

Additionally, the Threads MVP as it currently stands will degrade existing experiences such as but not limited to

  • Search results contexts will be missing or shorter than usual because the server is returning events from different timelines which must be filtered out.
  • Notifications are currently incomplete and it is hard to know where to look for unreads for some people, whereas in a reply-chain model (current) that is not an issue as everything is linear.

I don't disagree with default-on, but think users should have the ability to opt out should they want to, I cannot think of any other product which doesn't give you the option to switch from Beta back to Stable.

@novocaine
Copy link
Contributor Author

Search results contexts will be missing or shorter than usual because the server is returning events from different timelines which must be filtered out.

@t3chguy is there a defect issue for this?

@t3chguy
Copy link
Member

t3chguy commented Mar 29, 2022

@novocaine closest that exists is element-hq/element-meta#150 - the search and context APIs are both impacted

@novocaine
Copy link
Contributor Author

So I'm leaning towards agreeing that we should allow people to opt-out, mainly as we know our threads experience is a bit imperfect, particularly with regards to notifications. Given the current limitations, we are going to have some cranky users that don't know where notifications are coming from and find the behaviour unintuitive.

Opted-out users will perceive threads as reply-chains and have a "flattened" experience of them.

It looks like this is already supported by the beta component that we have, so its just a matter of supporting the button?

@janogarcia
Copy link

Yeah, Michael made a really good point regarding the notifications not being mature enough, and potentially introducing some undesired instability/unreliability to the app. 👍️

I probably focused too much on the "threads are not completely replacing an existing feature" mindset without being really aware of that undesired side effect, which has now become more clear as we discussed our plans on improving notifications.

kegsay added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 14, 2022
* Release threads as a beta feature ([\#8081](#8081)). Fixes element-hq/element-web#21351.
* More video rooms design updates ([\#8222](#8222)).
* Update video rooms to new design specs ([\#8207](#8207)). Fixes element-hq/element-web#21515, element-hq/element-web#21516 element-hq/element-web#21519 and element-hq/element-web#21526.
* Live Location Sharing - left panel warning with error ([\#8201](#8201)).
* Live location sharing - Stop publishing location to beacons with consecutive errors ([\#8194](#8194)).
* Live location sharing: allow retry when stop sharing fails ([\#8193](#8193)).
* Allow voice messages to be scrubbed in the timeline ([\#8079](#8079)). Fixes element-hq/element-web#18713.
* Live location sharing - stop sharing to beacons in rooms you left ([\#8187](#8187)).
* Allow sending and thumbnailing AVIF images ([\#8172](#8172)).
* Live location sharing - handle geolocation errors ([\#8179](#8179)).
* Show voice room participants when not connected ([\#8136](#8136)). Fixes element-hq/element-web#21513.
* Add margins between labs sections ([\#8169](#8169)).
* Live location sharing - send geolocation beacon events - happy path ([\#8127](#8127)).
* Add support for Animated (A)PNG ([\#8158](#8158)). Fixes element-hq/element-web#12967.
* Don't form continuations from thread roots ([\#8166](#8166)). Fixes element-hq/element-web#20908.
* Improve handling of animated GIF and WEBP images ([\#8153](#8153)). Fixes element-hq/element-web#16193 and element-hq/element-web#6684.
* Wire up file preview for video files ([\#8140](#8140)). Fixes element-hq/element-web#21539.
* When showing thread, always auto-focus its composer ([\#8115](#8115)). Fixes element-hq/element-web#21438.
* Live location sharing - refresh beacon expiry in room ([\#8116](#8116)).
* Use styled mxids in member list v2 ([\#8110](#8110)). Fixes element-hq/element-web#14825. Contributed by @SimonBrandner.
* Delete groups (legacy communities system) ([\#8027](#8027)). Fixes element-hq/element-web#17532.
* Add a prototype of voice rooms in labs ([\#8084](#8084)). Fixes element-hq/element-web#3546.
* Fix editing `<ol>` tags with a non-1 start attribute ([\#8211](#8211)). Fixes element-hq/element-web#21625.
* Fix URL previews being enabled when room first created ([\#8227](#8227)). Fixes element-hq/element-web#21659.
* Don't use m.call for Jitsi video rooms ([\#8223](#8223)).
* Scale emoji with size of surrounding text ([\#8224](#8224)).
* Make "Jump to date" translatable ([\#8218](#8218)).
* Normalize call buttons ([\#8129](#8129)). Fixes element-hq/element-web#21493. Contributed by @luixxiul.
* Show room preview bar with maximised widgets ([\#8180](#8180)). Fixes element-hq/element-web#21542.
* Update more strings to not wrongly mention room when it is/could be a space ([\#7722](#7722)). Fixes element-hq/element-web#20243 and element-hq/element-web#20910.
* Fix issue with redacting via edit composer flow causing stuck editStates ([\#8184](#8184)).
* Fix some image/video scroll jumps ([\#8182](#8182)).
* Fix "react error on share dialog" ([\#8170](#8170)). Contributed by @yaya-usman.
* Fix disambiguated profile in threads in bubble layout ([\#8168](#8168)). Fixes element-hq/element-web#21570. Contributed by @SimonBrandner.
* Responsive BetaCard on Labs ([\#8154](#8154)). Fixes element-hq/element-web#21554. Contributed by @luixxiul.
* Display button as inline in room directory dialog ([\#8164](#8164)). Fixes element-hq/element-web#21567. Contributed by @luixxiul.
* Null guard TimelinePanel unmount edge ([\#8171](#8171)).
* Fix beta pill label breaking ([\#8162](#8162)). Fixes element-hq/element-web#21566. Contributed by @luixxiul.
* Strip relations when forwarding ([\#7929](#7929)). Fixes element-hq/element-web#19769, element-hq/element-web#18067 element-hq/element-web#21015 and element-hq/element-web#10924.
* Don't try (and fail) to show replies for redacted events ([\#8141](#8141)). Fixes element-hq/element-web#21435.
* Fix 3pid member info for space member list ([\#8128](#8128)). Fixes element-hq/element-web#21534.
* Set max-width to user context menu ([\#8089](#8089)). Fixes element-hq/element-web#21486. Contributed by @luixxiul.
* Fix issue with falsey hrefs being sent in events ([\#8113](#8113)). Fixes element-hq/element-web#21417.
* Make video sizing consistent with images ([\#8102](#8102)). Fixes element-hq/element-web#20072.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants