Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device selection in EC video rooms doesn't always work #23331

Closed
robintown opened this issue Sep 21, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#9321
Closed

Device selection in EC video rooms doesn't always work #23331

robintown opened this issue Sep 21, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#9321
Assignees
Labels
T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@robintown
Copy link
Member

No description provided.

@robintown robintown changed the title Device selection in EW doesn't always work Device selection in EC video rooms doesn't always work Sep 21, 2022
@turt2live
Copy link
Member

Please define "doesn't work"

@turt2live turt2live added T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter labels Sep 21, 2022
@dbkr dbkr self-assigned this Sep 23, 2022
@dbkr
Copy link
Member

dbkr commented Sep 23, 2022

The problem here is indeed that the browser is giving different device IDs for the same device between the different origins. Our best bet is probably to pass the device list over the postmessage API from EC -> EW so EW can present them to the user, although we'll need to prompt for user media permission before we can get the names of the devices - maybe we can show a "please accept permissions" screen in the preview like we do in element call. Previewing the input in EW is going to be an issue though: we'll have to match up the device names, which means we'll also need to prompt for user media permission on the element web origin if we don't already have it...

@dbkr
Copy link
Member

dbkr commented Sep 23, 2022

As @robintown points out, if we're doing device name matching in EW to get the right preview, we may as well just pass the chosen devices over by device name rather than ID in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants