The lazy loading dialog is making repeat appearances

[robintown]

Steps to reproduce

According to a user's report:

1. Update to the latest develop.element.io
2. Get the lazy loading dialog
3. Press the OK button
4. Element reloads
5. goto 2

This is also reproducible by running any of our Cypress tests.

Outcome

What did you expect?

The lazy loading dialog should not appear

What happened instead?

Since the dialog appears repeatedly on each reload, this effectively blocks all interaction with the app.

Operating system

NixOS unstable

Browser information

Chromium 105.0.5195.125

URL for webapp

The develop branch

Application version

Element version: 8e841be-react-7a33818bd7ec-js-f398e3564d14 Olm version: 3.2.12

Homeserver

No response

Will you send logs?

No

[robintown]

matrix-org/matrix-js-sdk#2713 likely related

[robintown]

Tentative fix:

diff --git a/src/store/indexeddb-local-backend.ts b/src/store/indexeddb-local-backend.ts
index 0ab50db35..21166f575 100644
--- a/src/store/indexeddb-local-backend.ts
+++ b/src/store/indexeddb-local-backend.ts
@@ -167,6 +167,10 @@ export class LocalIndexedDBStoreBackend implements IIndexedDBBackend {
             logger.log(
                 `LocalIndexedDBStoreBackend.connect: upgrading from ${oldVersion}`,
             );
+            if (oldVersion < 1) {
+                // The database did not previously exist
+                this._isNewlyCreated = true;
+            }
             DB_MIGRATIONS.forEach((migration, index) => {
                 if (oldVersion <= index) migration(db);
             });

[t3chguy]

Regressed by matrix-org/matrix-js-sdk#2713