Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate IndexedDB versions automatically to reduce repeated information and possibilities for error #2713

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Calculate IndexedDB versions automatically to reduce repeated information and possibilities for error #2713

merged 1 commit into from
Sep 29, 2022

Conversation

duxovni
Copy link
Contributor

@duxovni duxovni commented Sep 28, 2022 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@duxovni duxovni added the T-Task Tasks for the team like planning label Sep 28, 2022
@duxovni duxovni requested a review from a team as a code owner September 28, 2022 18:18
SimonBrandner
SimonBrandner reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused as to why the version checks are not necessary?

@duxovni
Copy link
Contributor Author

duxovni commented Sep 29, 2022

The version checks are all still there, we're just using an actual for loop now, instead of writing out a for loop by hand and manually counting the number of iterations.

SimonBrandner
SimonBrandner approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, turns out I am very blind - sorry!

@duxovni duxovni merged commit f398e35 into develop Sep 29, 2022
@duxovni duxovni deleted the fayed/idb-version-preventative branch September 29, 2022 20:25
@robintown robintown mentioned this pull request Sep 30, 2022
Closed
@t3chguy t3chguy mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBrandner SimonBrandner SimonBrandner approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duxovni @SimonBrandner