Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element white-screen-of-deaths when I hang up a Matrix-native 1:1 call #23783

Closed
lampholder opened this issue Nov 17, 2022 · 6 comments · Fixed by element-hq/element-desktop#459 or element-hq/element-desktop#458
Assignees
Labels
A-Electron A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@lampholder
Copy link
Member

Steps to reproduce

  1. Start a call with Anthony (or Jordan)
  2. Chat away for a bit
  3. Go to a different room to enable PIP
  4. Hang up
  5. WSOD

Then you have to Task Manager kill the background processes to really terminate Element such that you can start it again cleanly.

Outcome

What did you expect?

No WSOD

What happened instead?

WSOD

Operating system

Windows 10

Application version

Element Nightly version: 0.0.1-nightly.2022111701 Olm version: 3.2.12

How did you install the app?

Website

Homeserver

lant.uk

Will you send logs?

Yes

@t3chguy
Copy link
Member

t3chguy commented Nov 17, 2022

Sounds like an OOM element-hq/element-desktop#680 - @lampholder can you check your system logs

@t3chguy t3chguy added the X-Needs-Info This issue is blocked awaiting information from the reporter label Nov 17, 2022
@t3chguy t3chguy changed the title Element white-screen-of-deaths when I hand up a Matrix-native 1:1 call Element white-screen-of-deaths when I hang up a Matrix-native 1:1 call Nov 18, 2022
@dbkr
Copy link
Member

dbkr commented Nov 18, 2022

Seems to be reproducible if the other side hangs up. I didn't have to enter pip mode.

@robintown robintown added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-VoIP A-Electron O-Occasional Affects or can be seen by some users regularly or most users rarely and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Nov 18, 2022
@robintown
Copy link
Member

I can't reproduce this in Firefox, so I'm assuming this is specific to the desktop app

@dbkr
Copy link
Member

dbkr commented Nov 18, 2022

Renderer process crash:

* thread vector-im/element-web#22, name = 'WebRTC_Network', stop reason = EXC_BAD_ACCESS (code=1, address=0x1f)
    frame #0: 0x0000000110aaaea8 Electron Framework`node::SetTracingController(v8::TracingController*) + 1118000
Electron Framework`node::SetTracingController:
->  0x110aaaea8 <+1118000>: ldrb   w8, [x1, #0x17]
    0x110aaaeac <+1118004>: tbnz   w9, #0x1f, 0x110aaaec8    ; <+1118032>
    0x110aaaeb0 <+1118008>: tbnz   w8, #0x7, 0x110aaaf10     ; <+1118104>
    0x110aaaeb4 <+1118012>: ldr    q0, [x1]
Target 0: (Electron Helper (Renderer)) stopped.
(lldb) bt
* thread vector-im/element-web#22, name = 'WebRTC_Network', stop reason = EXC_BAD_ACCESS (code=1, address=0x1f)
  * frame #0: 0x0000000110aaaea8 Electron Framework`node::SetTracingController(v8::TracingController*) + 1118000
    frame vector-im/element-web#1: 0x000000010b09af68 Electron Framework`v8::CpuProfileNode::GetParent() const + 54092
    frame vector-im/element-web#2: 0x000000010b09af68 Electron Framework`v8::CpuProfileNode::GetParent() const + 54092
    frame vector-im/element-web#3: 0x000000010b0997d4 Electron Framework`v8::CpuProfileNode::GetParent() const + 48056
    frame vector-im/element-web#4: 0x000000010b098638 Electron Framework`v8::CpuProfileNode::GetParent() const + 43548
    frame vector-im/element-web#5: 0x000000010b0982b4 Electron Framework`v8::CpuProfileNode::GetParent() const + 42648
    frame vector-im/element-web#6: 0x000000010b09dde8 Electron Framework`v8::CpuProfileNode::GetParent() const + 65996
    frame vector-im/element-web#7: 0x000000010c72cadc Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 2443644
    frame vector-im/element-web#8: 0x000000010af6e6f4 Electron Framework`v8::internal::DefaultEmbedderRootsHandler::ResetRoot(v8::TracedReference<v8::Value> const&) + 21744
    frame vector-im/element-web#9: 0x000000010d42d6f0 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16078224
    frame vector-im/element-web#10: 0x000000010d448394 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16187956
    frame vector-im/element-web#11: 0x000000010d3f64e4 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 15852420
    frame vector-im/element-web#12: 0x000000010d448d9c Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16190524
    frame vector-im/element-web#13: 0x000000010d4149c8 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 15976552
    frame vector-im/element-web#14: 0x000000010d462290 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16294192
    frame vector-im/element-web#15: 0x000000010d462404 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16294564
    frame vector-im/element-web#16: 0x000000010d47d9d0 Electron Framework`v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 16406640
    frame vector-im/element-web#17: 0x000000019843c26c libsystem_pthread.dylib`_pthread_start + 148

@dbkr
Copy link
Member

dbkr commented Nov 21, 2022

I'm still not really sure what's causing this crash - in a testing build, it crashes somewhere else before I can repro this crash. However, it seems fine with the previous build, v20.3.4, so I suggest downgrading to that for this release. If we want a fix for this release, our options are going to be limited to either downgrading one patch release or upgrading a major version (if indeed that fixes it - I haven't tested that).

https://github.com/electron/electron/releases/tag/v20.3.5 are the fixes we'd be missing out on: I don't believe any of them are critical. One is a crash when SSRCs are are not unique, but this crashes most times anyway.

dbkr added a commit to element-hq/element-desktop that referenced this issue Nov 21, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
dbkr added a commit to element-hq/element-desktop that referenced this issue Nov 21, 2022
@t3chguy
Copy link
Member

t3chguy commented Nov 21, 2022

Will accept backport into staging and upgrade to v21 to develop tomorrow

t3chguy pushed a commit to element-hq/element-desktop that referenced this issue Nov 22, 2022
Co-authored-by: t3chguy <t3chguy@users.noreply.github.com>
Co-authored-by: ElementRobot <releases@riot.im>
Fixes element-hq/element-web#23783
Fixes undefined
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Dec 6, 2022
* Update to Electron 21 ([\element-hq#458](element-hq#458)). Fixes element-hq/element-web#23783.
* Further improve replies ([\#6396](matrix-org/matrix-react-sdk#6396)). Fixes element-hq/element-web#19074, element-hq/element-web#18194 element-hq/element-web#18027 and element-hq/element-web#19179.
* Enable users to join group calls from multiple devices ([\#9625](matrix-org/matrix-react-sdk#9625)).
* fix(visual): make cursor a pointer for summaries ([\#9419](matrix-org/matrix-react-sdk#9419)). Contributed by @r00ster91.
* Add placeholder for rich text editor ([\#9613](matrix-org/matrix-react-sdk#9613)).
* Consolidate public room search experience ([\#9605](matrix-org/matrix-react-sdk#9605)). Fixes element-hq/element-web#22846.
* New password reset flow ([\#9581](matrix-org/matrix-react-sdk#9581)). Fixes element-hq/element-web#23131.
* Device manager - add tooltip to device details toggle ([\#9594](matrix-org/matrix-react-sdk#9594)).
* sliding sync: add lazy-loading member support ([\#9530](matrix-org/matrix-react-sdk#9530)).
* Limit formatting bar offset to top of composer ([\#9365](matrix-org/matrix-react-sdk#9365)). Fixes element-hq/element-web#12359. Contributed by @owi92.
* Fix issues around up arrow event edit shortcut ([\#9645](matrix-org/matrix-react-sdk#9645)). Fixes element-hq/element-web#18497 and element-hq/element-web#18964.
* Fix search not being cleared when clicking on a result ([\#9635](matrix-org/matrix-react-sdk#9635)). Fixes element-hq/element-web#23845.
* Fix screensharing in 1:1 calls ([\#9612](matrix-org/matrix-react-sdk#9612)). Fixes element-hq/element-web#23808.
* Fix the background color flashing when joining a call ([\#9640](matrix-org/matrix-react-sdk#9640)).
* Fix the size of the 'Private space' icon ([\#9638](matrix-org/matrix-react-sdk#9638)).
* Fix reply editing in rich text editor (https ([\#9615](matrix-org/matrix-react-sdk#9615)).
* Fix thread list jumping back down while scrolling ([\#9606](matrix-org/matrix-react-sdk#9606)). Fixes element-hq/element-web#23727.
* Fix regression with TimelinePanel props updates not taking effect ([\#9608](matrix-org/matrix-react-sdk#9608)). Fixes element-hq/element-web#23794.
* Fix form tooltip positioning ([\#9598](matrix-org/matrix-react-sdk#9598)). Fixes element-hq/element-web#22861.
* Extract Search handling from RoomView into its own Component ([\#9574](matrix-org/matrix-react-sdk#9574)). Fixes element-hq/element-web#498.
* Fix call splitbrains when switching between rooms ([\#9692](matrix-org/matrix-react-sdk#9692)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Electron A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
4 participants