Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Disabled] Flaky Playwright test Composer > Rich text editor > Mentions > Plain text mode > autocomplete behaviour tests #26037

Closed
richvdh opened this issue Aug 23, 2023 · 8 comments · Fixed by matrix-org/matrix-react-sdk#11467 or #28244
Closed

[Disabled] Flaky Playwright test Composer > Rich text editor > Mentions > Plain text mode > autocomplete behaviour tests #26037

richvdh opened this issue Aug 23, 2023 · 8 comments · Fixed by matrix-org/matrix-react-sdk#11467 or #28244
Labels
A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Flaky-Test A test is raising false alarms Z-Flaky-Test-Disabled The flaking test has been disabled

Comments

@richvdh
Copy link
Member

richvdh commented Aug 23, 2023 •
edited
Loading

https://cloud.cypress.io/projects/ppvnzg/runs/17305/overview/a047ea12-07b9-48f7-b45c-b8d91e31f1b8?roarHideRunsWithDiffGroupsAndTags=1 / https://github.com/matrix-org/matrix-js-sdk/actions/runs/5892086571/job/15980592743#step:8:331

      AssertionError: Timed out retrying after 10000ms: expected '<div.mx_WysiwygComposer_AutoCompleteWrapper>' not to be 'empty'
      at Context.eval (webpack:///./cypress/e2e/composer/composer.spec.ts:195:0)

It seems not to be running the auto-complete logic, at all?

Can't reproduce locally, a bit short of ideas here
@weeman1337 weeman1337 added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 24, 2023
richvdh added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 24, 2023
@richvdh
Add debug to diagnose flaky composer test
f9fc884 
Part of my attempts to fix element-hq/element-web#26037.

Nobody seems to know how this currently works, so let's add a load of debugging.
@richvdh richvdh mentioned this issue Aug 24, 2023
Merged
@richvdh
Copy link
Member Author

richvdh commented Aug 24, 2023

This seems to have been flaky for some time: https://cloud.cypress.io/projects/ppvnzg/runs/16892/overview?roarHideRunsWithDiffGroupsAndTags=1 shows it failing three weeks ago

@richvdh richvdh reopened this Aug 24, 2023
@richvdh richvdh changed the title Flaky Cypress test Composer > Rich text editor > Mentions > Plain text mode > autocomplete behaviour tests Flaky Cypress tests "Composer > {CIDER,Rich text editor} > Mentions > Plain text mode > autocomplete behaviour tests" Aug 24, 2023
@richvdh richvdh changed the title Flaky Cypress tests "Composer > {CIDER,Rich text editor} > Mentions > Plain text mode > autocomplete behaviour tests" Flaky Cypress tests "Composer > Rich text editor > Mentions > Plain text mode > autocomplete behaviour tests" Aug 24, 2023
@richvdh richvdh reopened this Oct 3, 2023
@richvdh
Copy link
Member Author

richvdh commented Oct 3, 2023

matrix-org/matrix-js-sdk#3770 / https://github.com/matrix-org/matrix-js-sdk/actions/runs/6395357104/job/17358912056

@richvdh richvdh changed the title Flaky Cypress tests "Composer > Rich text editor > Mentions > Plain text mode > autocomplete behaviour tests" Flaky Cypress test Composer > Rich text editor > Mentions > Plain text mode > autocomplete behaviour tests Oct 3, 2023
@richvdh
Copy link
Member Author

richvdh commented Oct 4, 2023

matrix-org/matrix-js-sdk#3770 / https://github.com/matrix-org/matrix-js-sdk/actions/runs/6404506416/job/17385218364#step:8:6509

@richvdh
Copy link
Member Author

richvdh commented Oct 5, 2023

matrix-org/matrix-js-sdk#3780 / https://github.com/matrix-org/matrix-js-sdk/actions/runs/6418316757/job/17425859159#step:8:257

@richvdh richvdh mentioned this issue Oct 5, 2023
Merged
@richvdh richvdh changed the title Flaky Cypress test Composer > Rich text editor > Mentions > Plain text mode > autocomplete behaviour tests [Disabled] Flaky Cypress test Composer > Rich text editor > Mentions > Plain text mode > autocomplete behaviour tests Oct 5, 2023
@richvdh
Copy link
Member Author

richvdh commented Feb 29, 2024

cypress is dead, long live playwright

@richvdh richvdh closed this as completed Feb 29, 2024
@richvdh
Copy link
Member Author

richvdh commented Feb 29, 2024

... except this is still disabled

@richvdh richvdh reopened this Feb 29, 2024
@richvdh richvdh changed the title [Disabled] Flaky Cypress test Composer > Rich text editor > Mentions > Plain text mode > autocomplete behaviour tests [Disabled] Flaky Playwright test Composer > Rich text editor > Mentions > Plain text mode > autocomplete behaviour tests Feb 29, 2024
@github-actions github-actions bot added the Stale label Apr 24, 2024
@github-actions GitHub Actions
Copy link

This flaky test issue has not been updated in 14 days. It is being closed as presumed resolved.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
@richvdh richvdh reopened this Apr 24, 2024
@github-actions github-actions bot added the Stale label May 17, 2024
@github-actions GitHub Actions
Copy link

This flaky test issue has not been updated in 14 days. It is being closed as presumed resolved.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
@MidhunSureshR MidhunSureshR added the Z-Flaky-Test-Disabled The flaking test has been disabled label Jun 19, 2024
@MidhunSureshR MidhunSureshR reopened this Jun 19, 2024
@langleyd langleyd mentioned this issue Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Flaky-Test A test is raising false alarms Z-Flaky-Test-Disabled The flaking test has been disabled
Projects
None yet
Milestone
No milestone
4 participants
@richvdh @weeman1337 @MidhunSureshR @RiotRobot