Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System font used for emojis #26643

Closed
turt2live opened this issue Nov 24, 2023 · 15 comments · Fixed by matrix-org/matrix-react-sdk#11935
Closed

System font used for emojis #26643

turt2live opened this issue Nov 24, 2023 · 15 comments · Fixed by matrix-org/matrix-react-sdk#11935
Assignees
Labels
A-Emoji O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Open the app
  2. Send a flag emoji

Outcome

What did you expect?

Our specific font emoji.

What happened instead?

image

This should be a Canadian flag, but Windows doesn't have proper flag emoji so it renders like this.

This broke with today's nightly.

Operating system

Windows 11

Application version

Element Nightly version: 0.0.1-nightly.2023112401 Crypto version: Olm 3.2.15

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

Yes

@t3chguy
Copy link
Member

t3chguy commented Nov 24, 2023

This was done intentionally, twemoji no longer receives updates due to twitter>x. You can enable the bundled (outdated) font under settings > Appearance or update your system fonts

@Johennes
Copy link
Contributor

I honestly cannot believe that Windows 11 doesn't have a 🇨🇦 emoji. Have you customized any font settings at the OS level?

@turt2live
Copy link
Member Author

Nope, this is a stock Windows install. Windows has never had country flags in its emoji font, which makes issues like this easy to check :)

@Johennes
Copy link
Contributor

Ok, we might have to reconsider twemoji alternatives then.

@Johennes
Copy link
Contributor

Tested myself and while most emoji from our picker are present on Windows a few notable ones and most country flags are missing.

Screenshot 2023-11-27 at 08 08 22
Screenshot 2023-11-27 at 08 08 37
Screenshot 2023-11-27 at 08 09 02
Screenshot 2023-11-27 at 08 09 22

@Johennes
Copy link
Contributor

So the gaps aren't giant but still quite annoying and it worries me when not even Windows has good emoji coverage. @t3chguy is going to revert the change mentioned in #26643 (comment) and we'll reconsider alternatives.

A quick Google search turned up https://github.com/googlefonts/noto-emoji. It has a concerning disclaimer in its README...

NotoColorEmoji uses the CBDT/CBLC color font format, which is supported by Android and Chrome/Chromium OS. Windows supports it starting with Windows 10 Anniversary Update in Chrome and Edge. On macOS, only Chrome supports it, while on Linux it will support it with some fontconfig tweaking, see googlefonts/noto-emoji#36. Currently we do not build other color font formats.

...but appears to be working fine in my quick testing with Firefox on macOS.

Screenshot 2023-11-27 at 08 34 50

@t3chguy t3chguy self-assigned this Nov 27, 2023
@weeman1337 weeman1337 added X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Emoji O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Nov 27, 2023
@davidegirardi
Copy link

I'm using Arch and the noto-fonts-emoji package comes with just the font itself and the license file. I didn't do any special configuration to make it work.

@Johennes
Copy link
Contributor

What I meant above was that we could bundle Noto instead of Twemoji. So then I think you wouldn't have to have it installed on your system.

@davidegirardi
Copy link

Of course but your quote mentions some tweaks needed for Linux. That's not my experience, which is a positive thing.

@Johennes
Copy link
Contributor

Of course but your quote mentions some tweaks needed for Linux. That's not my experience, which is a positive thing.

Ohh, I see. Sorry, had misunderstood you.

@turt2live
Copy link
Member Author

An upside to the Windows default font is I could finally see the + emoji, for once:

image

@turt2live
Copy link
Member Author

Not sure matrix-org/matrix-react-sdk#11935 worked:

The option is checked:

image

but isn't being applied:

image

@turt2live turt2live reopened this Dec 1, 2023
@t3chguy
Copy link
Member

t3chguy commented Dec 1, 2023

@turt2live have you tried turning it off and on again? Sounds like #26248

@turt2live
Copy link
Member Author

Turning it off and on works for the active session, but after I reload it's back to being unbundled emoji. There is a notable light->dark switch during my application load, however.

@t3chguy
Copy link
Member

t3chguy commented Dec 1, 2023

Duplicate of #26248

@t3chguy t3chguy marked this as a duplicate of #26248 Dec 1, 2023
@t3chguy t3chguy closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Emoji O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants