Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag and drop the (X) button on links preview shouldn't be allowed #27186

Closed
ahmedhosssam opened this issue Mar 14, 2024 · 3 comments · Fixed by matrix-org/matrix-react-sdk#12450
Closed

Drag and drop the (X) button on links preview shouldn't be allowed #27186

ahmedhosssam opened this issue Mar 14, 2024 · 3 comments · Fixed by matrix-org/matrix-react-sdk#12450
Labels
good first issue Good for newcomers Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ahmedhosssam
Copy link

ahmedhosssam commented Mar 14, 2024 •
edited
Loading

Steps to reproduce

Hi everyone,
I found a bug in the (X) button in the link preview in Element app on the browser, I can drag and drop it as if I upload an image.
It should be modified.

outputv.mp4

Outcome

What did you expect?

It should be static

What happened instead?

I can drag and drop the icon

Operating system

Arch Linux

Browser information

Microsoft Edge 120.0.2210.121 (Official build) (64-bit)

URL for webapp

https://app.element.io/

Application version

No response

Homeserver

matrix.org

Will you send logs?

Yes
@dbkr dbkr added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers labels Mar 18, 2024
@github-actions github-actions bot added the Help Wanted Extra attention is needed label Mar 18, 2024
@asimdelvi
Copy link
Contributor

Can you assign this issue to me?

@t3chguy
Copy link
Member

t3chguy commented Apr 22, 2024

@asimdelvi see https://github.com/element-hq/element-meta/wiki/Guidance-on-assigning-issues

@asimdelvi
Copy link
Contributor

@t3chguy, added a draft PR, but it's failing as not able to add labels.

matrix-org/matrix-react-sdk#12450

@asimdelvi asimdelvi mentioned this issue Apr 23, 2024
Merged
4 tasks
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@asimdelvi
Fixed the drag and drop of X ##27186 (#12450)
158e111
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@asimdelvi
Fixed custom emotes background color #27745 (#12798)
92bf203 
* Fixed the drag and drop of X ##27186

* Fixed custom emotes background color #27745

* Fixed custom emotes background color #27745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed the drag and drop of X #27186 asimdelvi/matrix-react-sdk
4 participants
@dbkr @t3chguy @asimdelvi @ahmedhosssam