Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Account" header with nothing below it in General settings if you can't set your password #27756

Closed
Twi1ightSparkle opened this issue Jul 16, 2024 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12791
Closed

"Account" header with nothing below it in General settings if you can't set your password #27756

Twi1ightSparkle opened this issue Jul 16, 2024 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12791
Labels
A-App Settings Application settings A-User-Settings O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@Twi1ightSparkle
Copy link

Steps to reproduce

  • go to settings

Outcome

What did you expect?

What happened instead?

An extra header with nothing below it

screenshot_2024-07-16T14-23-50Z

Dave said

ah, should be hidden if you can't set your password

Operating system

Fedora 40

Application version

Desktop Element version: 1.11.71 Crypto version: Rust SDK 0.7.1 (80a151e), Vodozemac 0.6.0

How did you install the app?

From https://packages.element.io

Homeserver

element.io

Will you send logs?

No
@dbkr dbkr added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-App Settings Application settings labels Jul 16, 2024
@dosubot dosubot bot added A-User-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users labels Jul 16, 2024
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 18, 2024
@dbkr
Fix stray 'account' heading
5bfecf4 
There's nothing in the 'account' section other than the password
change control now, so remove the whole section if you can't change
your password.

Fixes element-hq/element-web#27756
@dbkr dbkr mentioned this issue Jul 18, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 18, 2024
@dbkr
Fix stray 'account' heading (#12791)
564ea53 
* Fix stray 'account' heading

There's nothing in the 'account' section other than the password
change control now, so remove the whole section if you can't change
your password.

Fixes element-hq/element-web#27756

* Unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-App Settings Application settings A-User-Settings O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stray 'account' heading matrix-org/matrix-react-sdk
3 participants
@dbkr @t3chguy @Twi1ightSparkle