Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkify chokes on underscores in room aliases #500

Closed
matrixbot opened this issue Dec 11, 2015 · 3 comments · Fixed by matrix-org/matrix-react-sdk#495
Closed

linkify chokes on underscores in room aliases #500

matrixbot opened this issue Dec 11, 2015 · 3 comments · Fixed by matrix-org/matrix-react-sdk#495
Assignees
@aviraldg
Labels
P2 T-Defect
Milestone
v1 - Private Preview

Comments

@matrixbot
Copy link

Created by @ matthew:matrix.org.
@ara4n
Copy link
Member

ara4n commented Dec 13, 2015

This is annoying as it breaks all bridged room aliases.

@ara4n ara4n closed this as completed Dec 13, 2015
@ara4n ara4n reopened this Dec 13, 2015
@ara4n ara4n mentioned this issue Jan 11, 2016
Closed
@ara4n ara4n changed the title linkifier chokes on _'s in room aliases linkify chokes on underscores in room aliases Jan 11, 2016
@AmandineLP AmandineLP added this to the v1 - Private Preview milestone Jan 12, 2016
@ara4n
Copy link
Member

ara4n commented Sep 13, 2016

@aviraldg tried to fix this in matrix-org/matrix-react-sdk#471 but bumping the linkify dep caused problems. Need to do a new PR.

dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 21, 2016
@dbkr
Fix linkifying rooms with underscores, try 2
59117f1 
Fixes element-hq/element-web#500
@dbkr
Copy link
Member

dbkr commented Sep 21, 2016

FTR, I just had a quick look at this and summarised the problems in #2010

Basically, we either accept that linkify now treats nonbreaking spaces are part of the url and change the topic of riot feedback to contain normal space characters, or try to hunt down and fix that behaviour in linkify.

@dbkr dbkr mentioned this issue Sep 23, 2016
Merged
@dbkr dbkr closed this as completed Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aviraldg aviraldg

Labels
P2 T-Defect
Projects
None yet
Milestone
v1 - Private Preview
Development

Successfully merging a pull request may close this issue.

Fix links to IRC rooms matrix-org/matrix-react-sdk
5 participants
@aviraldg @dbkr @ara4n @AmandineLP @matrixbot