-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scroll position is still jerky when backfilling #528
Comments
Matthew is still observing jerky scroll position when we are backfilling: specifically, when doing a two-finger scroll backwards in time, the scroll position sometimes jumps to the top of the room rather than preserving position. |
The problem is that we see a scroll event arriving after we reset the scroll position, but with the scroll offset reset to old values:
We could hack around this by ignoring the scroll events until we get one which (roughly?) matches the scroll offset we assigned... but that feels ugly and fragile. I'd like to understand what is causing the reset. |
Keep resetting our scroll offset until the DOM believes us. Hopefully this will fix element-hq/element-web#528.
Hopefully this has been fixed by matrix-org/matrix-react-sdk#56 |
Under certain conditions, it was possible to get stuck in a state where any user-initiated scroll would be met with "Working around element-hq/element-web#528" and overridden. Fix this by removing the duplication between _lastSetScroll and recentEventScroll, and using _lastSetScroll which is more reliable.
Created by @ richvdh:matrix.org.
The text was updated successfully, but these errors were encountered: