Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors on first sync are swallowed (especially MAU error) #7148

Closed
dbkr opened this issue Aug 6, 2018 · 1 comment
Closed

Errors on first sync are swallowed (especially MAU error) #7148

dbkr opened this issue Aug 6, 2018 · 1 comment
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@dbkr
Copy link
Member

dbkr commented Aug 6, 2018

Any sync errors during the first sync are just logged to the console but the user continues to see a spinner with no feedback. We should show something to reflect the fact that things aren't going well (but we are still trying).

In the MAU case, if somehow the server allows you to log in but not sync due to a MAU limit, we'll hit this case and you get to stare at a spinner for a long, long time.
@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Aug 13, 2018
@lampholder
Copy link
Member

This feels like it could be the cause of quite a few riot-spins-infinitely errors; would probably be a good one to fix.

dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 7, 2018
@dbkr
Error on splash screen if sync is failing
fa669bf 
Display an error on the splash screen with the spinner if the sync
request is not working, rather than just sitting there with a spinner
as if nothing is wrong.

Fixes element-hq/element-web#7148
@dbkr dbkr mentioned this issue Sep 7, 2018
Merged
@dbkr dbkr closed this as completed Sep 7, 2018
@ara4n ara4n mentioned this issue Sep 30, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbkr @lampholder