Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riot doesn't persist non-sent messages (as it says it does) #7177

Closed
bwindels opened this issue Aug 16, 2018 · 2 comments · Fixed by matrix-org/matrix-js-sdk#1655
Closed
Assignees
Labels
A-Composer A-Storage Storage layer of the app, including IndexedDB, local storage, etc. P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Chronic

Comments

@bwindels
Copy link
Contributor

bwindels commented Aug 16, 2018

Noticed this while matrix.org went down for maintenance:

Repro steps:

  • go to a room
  • make server go offline
  • type some messages, you'll be told the connectivty to the server was lost and your messages were saved and will be sent when the server comes back
  • close riot
  • open riot again
  • unsent messages are not shown anymore
  • make server come online again
  • unsent messages are never sent
@lampholder
Copy link
Member

Yep, something should change (either the expectations of the users should be properly set or the messages should be properly locally persisted).

FWIW this seems to be the case on certainly Riot Android too.

@lampholder lampholder added T-Defect ui/ux P1 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Aug 20, 2018
@JuniorJPDJ
Copy link
Contributor

I will then repaste my message from closed issue:

Riot allows to refresh page when there are messages waiting to be sent.
IMO it should ask for confirmation or at least save them or save them in local storage.

The infobox telling user "messages will be sent when server is available" is confusing, it makes user feel like messages are saved at user side, but it's not the case, you can't close browser nor refresh page.

Just asking user if he really want to close page should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Storage Storage layer of the app, including IndexedDB, local storage, etc. P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Chronic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants