Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist unsent messages for subsequent sessions #1655

Merged
merged 5 commits into from
Apr 9, 2021

Conversation

germain-gg
Copy link
Contributor

Fixes element-hq/element-web#7177

This pull requests hooks into the Room#_pendingEventList flow to store a serialised version of an unsent MatrixEvent.

The storage key is: mx_pending_events_${roomId}

Upon instanciation the Room model will query the storage and populate _pendingEventList if required. Element then picks up the unsent messages and display the RoomStatusBar and a user can decide whether to send or cancel the queued messages

@germain-gg germain-gg requested a review from a team April 1, 2021 10:05
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm!

src/models/room.js Outdated Show resolved Hide resolved
@jryans
Copy link
Collaborator

jryans commented Apr 9, 2021

@gsouquet What's the status of this one? Looks like perhaps merging develop to get the cross-signing test fix would get things moving again?

@germain-gg
Copy link
Contributor Author

@gsouquet What's the status of this one? Looks like perhaps merging develop to get the cross-signing test fix would get things moving again?

Yeah, I was waiting on ops to give me access to BuildKite so that I can re-run the pipelines, but can do that too 👍

@germain-gg germain-gg merged commit 8377641 into develop Apr 9, 2021
@germain-gg germain-gg deleted the gsouquet-persist-unsent-messages branch April 9, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Riot doesn't persist non-sent messages (as it says it does)
4 participants