Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e context menu should not appear on non-e2e msgs #8551

Closed
ara4n opened this issue Feb 13, 2019 · 3 comments
Closed

e2e context menu should not appear on non-e2e msgs #8551

ara4n opened this issue Feb 13, 2019 · 3 comments
Assignees
@turt2live
Labels
A-E2EE A-Timeline P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Feb 13, 2019

No description provided.

@ara4n
Copy link
Member Author

ara4n commented Feb 13, 2019

i.e. the bottom line of the context menu is spurious in a non-e2e room

screenshot 2019-02-13 at 11 20 50

@lampholder lampholder changed the title e2e context menu should surely not appear on non-e2e msgs e2e context menu should not appear on non-e2e msgs Feb 13, 2019
@lampholder
Copy link
Member

yep

@lampholder lampholder added T-Defect ui/ux P2 S-Minor Impairs non-critical functionality or suitable workarounds exist A-E2EE A-Timeline labels Feb 19, 2019
@turt2live turt2live self-assigned this Feb 22, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 22, 2019
@turt2live
Only set e2e info callback if the event is encrypted
20cd198 
Fixes element-hq/element-web#8551
@turt2live turt2live mentioned this issue Feb 22, 2019
Merged
@turt2live
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#2684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-E2EE A-Timeline P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @ara4n @lampholder