Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Passwords don't match' doesn't disappear even when they match #8769

Closed
anoadragon453 opened this issue Feb 18, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#2672
Closed

'Passwords don't match' doesn't disappear even when they match #8769

anoadragon453 opened this issue Feb 18, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#2672
Assignees
@jryans
Labels
A-Authentication A-Registration P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@anoadragon453
Copy link
Member

Description

When creating an account, you may end up typing a password and a confirmation password. All is well you think, but oh noes!! You messed up and they don't match! Riot helpfully warns you of this before you click Register by showing a little "Passwords don't match" error at the top.

With lowered self-esteem, you go back to re-enter both passwords. Clicking off though, you see that "Passwords don't match" is still at the top! Is this right? Are you that tired that you still can't type your password twice?! You try again, and again. You resort to copy/pasting, but the error still persists!!!

And then, with a hint of faith, you click Register and find out your passwords were the same, you just messed up once.

The error should disappear once your passwords match, possibly even without clicking/tabbing off the field.

Steps to reproduce

  • Click Create Account
  • Type in your details with a mismatching password and confirmation password
  • Fix the passwords
  • See that "Passwords don't match error never leeeeaves

Version information

  • Platform: web

For the web app:

  • Browser: Firefox
  • OS: Debian Linux
  • URL: riot.im/develop
@jryans jryans added T-Defect P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Registration defect labels Feb 19, 2019
@jryans
Copy link
Collaborator

jryans commented Feb 19, 2019

I agree that's quite annoying. 😭

@bwindels bwindels mentioned this issue Feb 19, 2019
Closed
41 tasks
@jryans jryans self-assigned this Feb 21, 2019
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Feb 21, 2019
@jryans
Report validity state of all registration fields on any change
86a375c 
This passes the validity state of all fields to the consumer of
`RegistrationForm` via the `onValdiationChange` callback, instead of just the
most recent error.

In addition, we notify the consumer for any validation change, whether success
or failure. This allows old validation messages to be properly cleared. It also
allows the consumer to be aware of multiple validation errors and display the
next one after you have fixed the first.

Fixes element-hq/element-web#8769
@jryans jryans mentioned this issue Feb 21, 2019
Merged
@jryans
Copy link
Collaborator

jryans commented Feb 26, 2019

Fixed by matrix-org/matrix-react-sdk#2672

@jryans jryans closed this as completed Feb 26, 2019
@anoadragon453
Copy link
Member Author

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Authentication A-Registration P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report validity state of all registration fields on any change jryans/matrix-react-sdk
3 participants
@jryans @anoadragon453 @lampholder