Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breadcrumbs are slightly eaten #9034

Closed
AmandineLP opened this issue Mar 4, 2019 · 1 comment
Closed

breadcrumbs are slightly eaten #9034

AmandineLP opened this issue Mar 4, 2019 · 1 comment
Assignees
@turt2live
Labels
A-Breadcrumbs S-Tolerable Low/no impact on users T-Defect
Milestone
Breadcrumbs: Out ...

Comments

@AmandineLP
Copy link
Contributor

AmandineLP commented Mar 4, 2019 •
edited
Loading

image
@anoadragon453
Copy link
Member

Possible duplicate of #8954

@turt2live turt2live added this to the Breadcrumbs: Out of labs milestone Mar 27, 2019
@turt2live turt2live self-assigned this Mar 27, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 27, 2019
@turt2live
Support horizontal scrolling on breadcrumbs
9b64dd0 
Fixes element-hq/element-web#8714
Fixes element-hq/element-web#8890
Fixes element-hq/element-web#9034
Fixes element-hq/element-web#8954

This turned out to be much more complicated than it needed to be. We use an IndicatorScrollbar to do all the math for us and some minor changes have been made so it can flag left/right overflow. The complicated part is the css changes which make the gradients work: unlike the RoomSubList, we have to calculate the offset of the indicators (gradients) on our own because position:sticky doesn't work horizontally.

The changes to the css (well, mostly pointer-events:none) make it so the gradient doesn't interfere with the room avatars. 

9034 and 8954 are fixed by this because they represent an overflow-x:none style breakage where browsers won't let you scroll without a scrollbar. The gradient offset problem is also demonstrated in 8954.
@turt2live turt2live mentioned this issue Mar 27, 2019
Merged
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Breadcrumbs S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
Breadcrumbs: Out of labs
Development

No branches or pull requests
5 participants
@jryans @turt2live @anoadragon453 @lampholder @AmandineLP