Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactions: Add primary reactions as message actions #9576

Closed
jryans opened this issue Apr 26, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#2937
Closed

Reactions: Add primary reactions as message actions #9576

jryans opened this issue Apr 26, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#2937
Assignees
@jryans
Labels
A-Aggregations A-Reactions T-Enhancement

Comments

@jryans
Copy link
Collaborator

jryans commented Apr 26, 2019

In the message action bar, alongside a button that opens the emoji picker to choose any emoji, we should also offer easy access to the primary emoji types:

  • 👍 / 👎
  • 🙂 / 😔
This was referenced Apr 29, 2019
Closed
Closed
@jryans jryans self-assigned this Apr 29, 2019
@NotAFile
Copy link
Contributor

How were the primary emoji types decided? Of course, you can bikeshed endlessly over this, but I think 👍🙂 and their opposites are nearly identical in meaning. I assume the plan is to just make the featured ones the most "frecent" in the future?

@jryans
Copy link
Collaborator Author

jryans commented Apr 30, 2019

How were the primary emoji types decided? Of course, you can bikeshed endlessly over this, but I think 👍🙂 and their opposites are nearly identical in meaning. I assume the plan is to just make the featured ones the most "frecent" in the future?

These primary types are meant to have additional meaning in that they will also serve as signals in a future reputation system. I would encourage you to join #matrix-reputation:matrix.org if you're interested in more details here.

The primary emoji themselves would not change over time. Other emoji would be accessed separately through a larger emoji picker.

jryans added a commit to jryans/matrix-react-sdk that referenced this issue Apr 30, 2019
@jryans
Add primary reactions to action bar
784599d 
This adds the primary reactions to the action bar. They act as toggles where you
can only select one from each group at a time.

Note that currently we aren't actually sending the reaction at all. That's left
for a separate task.

Fixes element-hq/element-web#9576
@jryans jryans mentioned this issue Apr 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Aggregations A-Reactions T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add primary reactions to action bar jryans/matrix-react-sdk
3 participants
@jryans @lampholder @NotAFile