Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links preview does not work reliably #9880

Closed
akontsevich opened this issue May 29, 2019 · 11 comments
Closed

Links preview does not work reliably #9880

akontsevich opened this issue May 29, 2019 · 11 comments
Labels
P2 T-Defect Z-Synapse

Comments

@akontsevich
Copy link

akontsevich commented May 29, 2019 •
edited by lampholder
Loading

Description

Links preview does not work reliably on mobile, web and desktop versions. Related to #9310.

Version information

  • Platform: both: web (in-browser) and desktop and mobile

For the web app:

  • Browser: Firefox
  • OS: Linux
  • URL: riot.im/develop & riot.im/app & desktop

For the desktop app:

  • OS: SUSE Linux
  • Version: 1.1.2
@jryans
Copy link
Collaborator

jryans commented May 29, 2019

Can you describe in more detail? Does it fail all the time for certain links? What's an example link that fails for you?

URL preview is currently done on the server. See https://github.com/vector-im/riot-web/issues/2953 for some past discussion about considering moving to the client. There are various setting to control URL preview per account and per room if you are worried about leaking URLs to the HS.

@akontsevich
Copy link
Author

Today all the time completely fails, previous days partially - shown some link, some - not. Happen with any link: youtube, news, blogs, whatever, etc.

@lampholder
Copy link
Member

I'm afraid we're going to need some more information to help debug this:

  • is your account on matrix.org?
  • is URL preview enabled in your User Settings (Preferences: Timeline)?
  • is encryption enabled in the rooms?
  • is URL preview enabled for participants in the Room Settings (General)? (this setting doesn not appear if the room is encrypted)
  • is URL preview enabled for you in the Room Settings (General)?
  • how long are you waiting for the URL previews to render?
  • please do provide specific examples of actual URLs
  • please do provide specific examples of times of failure - it could be that the server is just overloaded at the times you're trying to preview, causing the requests to time out

@lampholder lampholder changed the title Links preview does not work all the time Links preview does not work reliably May 30, 2019
@lampholder
Copy link
Member

@akontsevich I hope you don't mind I edited the original issue for clarity - we can use this issue to track URL previews not working reliably and element-hq/element-meta#1138 can continue to be used to track (perhaps optionally) making URL previews work client side.

@lampholder
Copy link
Member

Also URL previews aren't yet implemented on iOS, so if you were trying to use them there that will explain the failure.

@akontsevich
Copy link
Author

akontsevich commented May 30, 2019 •
edited
Loading 

* is your account on matrix.org?

Yes!

* is URL preview enabled in your User Settings (Preferences: Timeline)?

Sure, it worked before, stopped few days ago, nothing changed in settings.

* is encryption enabled in the rooms?

No.

* is URL preview enabled for participants in the Room Settings (General)? (this setting doesn not appear if the room is encrypted)

Yes! However bug appears regardless of this setting.

* is URL preview enabled for _you_ in the Room Settings (General)?

Yes.

* how long are you waiting for the URL previews to render?

Hours, previously worked almost immediately.

* please do provide specific examples of actual URLs

Any youtube video, another example: http://**************/?p=1624

* please do provide specific examples of times of failure - it could be that the server is just overloaded at the times you're trying to preview, causing the requests to time out

Does not work for 3-5 days already.

Also URL previews aren't yet implemented on iOS, so if you were trying to use them there that will explain the failure.

No, I mean Android devices: preview stopped to work on them as well.

@turt2live
Copy link
Member

This looks to be limited to matrix.org users only. Some URLs do work, however the one you've mentioned indeed does not work.

@turt2live
Copy link
Member

From some investigation: it's because the image from the preview cannot be downloaded. Have opened matrix-org/synapse#5298 to track fixing it.

@akontsevich
Copy link
Author

akontsevich commented May 30, 2019 •
edited
Loading

This is preview from Skype, for example. However it is not the only problem: as I mentioned nothing from youtube works, many other sites like this: https://hdrezka-me.me/22654-teni-ischezayut-v-polden-95051943.html, livejournal, etc - nothing works actually.

@akontsevich
Copy link
Author

Inserting new youtube link shows preview, however all previous links or on next days links are not previewed. So could be both synapse and client bugs.

@turt2live
Copy link
Member

It's a Synapse bug, as you're aware. Please don't comment on closed issues :/

su-ex added a commit to SchildiChat/element-web that referenced this issue Feb 28, 2023
@su-ex
Merge tag 'v1.11.23' into sc
2f22522 
* Description of QR code sign in labs feature ([\element-hq#23513](element-hq#23513)). Contributed by @hughns.
* Add option to find own location in map views ([\element-hq#10083](matrix-org/matrix-react-sdk#10083)).
* Render poll end events in timeline ([\element-hq#10027](matrix-org/matrix-react-sdk#10027)). Contributed by @kerryarchibald.
* Indicate unread messages in tab title ([\element-hq#10096](matrix-org/matrix-react-sdk#10096)). Contributed by @tnt7864.
* Open message in editing mode when keyboard up is pressed (RTE) ([\element-hq#10079](matrix-org/matrix-react-sdk#10079)). Contributed by @florianduros.
* Hide superseded rooms from the room list using dynamic room predecessors ([\element-hq#10068](matrix-org/matrix-react-sdk#10068)). Contributed by @andybalaam.
* Support MSC3946 in RoomListStore ([\element-hq#10054](matrix-org/matrix-react-sdk#10054)). Fixes element-hq#24325. Contributed by @andybalaam.
* Auto focus security key field ([\element-hq#10048](matrix-org/matrix-react-sdk#10048)).
* use Poll model with relations API in poll rendering ([\element-hq#9877](matrix-org/matrix-react-sdk#9877)). Contributed by @kerryarchibald.
* Support MSC3946 in the RoomCreate tile ([\element-hq#10041](matrix-org/matrix-react-sdk#10041)). Fixes element-hq#24323. Contributed by @andybalaam.
* Update labs flag description for RTE ([\#10058](matrix-org/matrix-react-sdk#10058)). Contributed by @florianduros.
* Change ul list style to disc when editing message ([\element-hq#10043](matrix-org/matrix-react-sdk#10043)). Contributed by @alunturner.
* Improved click detection within PiP windows ([\element-hq#10040](matrix-org/matrix-react-sdk#10040)). Fixes element-hq#24371.
* Add RTE keyboard navigation in editing ([\element-hq#9980](matrix-org/matrix-react-sdk#9980)). Fixes element-hq#23621. Contributed by @florianduros.
* Paragraph integration for rich text editor ([\element-hq#10008](matrix-org/matrix-react-sdk#10008)). Contributed by @alunturner.
* Add  indentation increasing/decreasing to RTE ([\element-hq#10034](matrix-org/matrix-react-sdk#10034)). Contributed by @florianduros.
* Add ignore user confirmation dialog ([\element-hq#6116](matrix-org/matrix-react-sdk#6116)). Fixes element-hq#14746.
* Use monospace font for room, message IDs in View Source modal ([\element-hq#9956](matrix-org/matrix-react-sdk#9956)). Fixes element-hq#21937. Contributed by @paragpoddar.
* Implement MSC3946 for AdvancedRoomSettingsTab ([\#9995](matrix-org/matrix-react-sdk#9995)). Fixes element-hq#24322. Contributed by @andybalaam.
* Implementation of MSC3824 to make the client OIDC-aware ([\element-hq#8681](matrix-org/matrix-react-sdk#8681)). Contributed by @hughns.
* Improves a11y for avatar uploads ([\element-hq#9985](matrix-org/matrix-react-sdk#9985)). Contributed by @GoodGuyMarco.
* Add support for [token authenticated registration](https ([\element-hq#7275](matrix-org/matrix-react-sdk#7275)). Fixes element-hq#18931. Contributed by @govynnus.
* Jitsi requests 'requires_client' capability if auth token is provided ([\element-hq#24294](element-hq#24294)). Contributed by @maheichyk.
* Remove duplicate white space characters from translation keys ([\element-hq#10152](matrix-org/matrix-react-sdk#10152)). Contributed by @luixxiul.
* Fix the caption of new sessions manager on Labs settings page for localization ([\element-hq#10143](matrix-org/matrix-react-sdk#10143)). Contributed by @luixxiul.
* Prevent start another DM with a user if one already exists ([\element-hq#10127](matrix-org/matrix-react-sdk#10127)). Fixes element-hq#23138.
* Remove white space characters before the horizontal ellipsis ([\element-hq#10130](matrix-org/matrix-react-sdk#10130)). Contributed by @luixxiul.
* Fix Selectable Text on 'Delete All' and 'Retry All' Buttons ([\element-hq#10128](matrix-org/matrix-react-sdk#10128)). Fixes element-hq#23232. Contributed by @akshattchhabra.
* Correctly Identify emoticons ([\element-hq#10108](matrix-org/matrix-react-sdk#10108)). Fixes element-hq#19472. Contributed by @adarsh-sgh.
* Should open new 1:1 chat room after leaving the old one ([\element-hq#9880](matrix-org/matrix-react-sdk#9880)). Contributed by @ahmadkadri.
* Remove a redundant white space ([\element-hq#10129](matrix-org/matrix-react-sdk#10129)). Contributed by @luixxiul.
* Fix a crash when removing persistent widgets (updated) ([\element-hq#10099](matrix-org/matrix-react-sdk#10099)). Fixes element-hq#24412. Contributed by @andybalaam.
* Fix wrongly grouping 3pid invites into a single repeated transition ([\element-hq#10087](matrix-org/matrix-react-sdk#10087)). Fixes element-hq#24432.
* Fix scrollbar colliding with checkbox in add to space section ([\element-hq#10093](matrix-org/matrix-react-sdk#10093)). Fixes element-hq#23189. Contributed by @Arnabdaz.
* Add a whitespace character after 'broadcast?' ([\element-hq#10097](matrix-org/matrix-react-sdk#10097)). Contributed by @luixxiul.
* Seekbar in broadcast PiP view is now updated when switching between different broadcasts ([\element-hq#10072](matrix-org/matrix-react-sdk#10072)). Fixes element-hq#24415.
* Add border to "reject" button on room preview card for clickable area indication. It fixes element-hq#22623 ([\element-hq#9205](matrix-org/matrix-react-sdk#9205)). Contributed by @gefgu.
* Element-R: fix rageshages ([\element-hq#10081](matrix-org/matrix-react-sdk#10081)). Fixes element-hq#24430.
* Fix markdown paragraph display in timeline ([\element-hq#10071](matrix-org/matrix-react-sdk#10071)). Fixes element-hq#24419. Contributed by @alunturner.
* Prevent the remaining broadcast time from being exceeded ([\#10070](matrix-org/matrix-react-sdk#10070)).
* Fix cursor position when new line is created by pressing enter (RTE) ([\element-hq#10064](matrix-org/matrix-react-sdk#10064)). Contributed by @florianduros.
* Ensure room is actually in space hierarchy when resolving its latest version ([\element-hq#10010](matrix-org/matrix-react-sdk#10010)).
* Fix new line for inline code ([\element-hq#10062](matrix-org/matrix-react-sdk#10062)). Contributed by @florianduros.
* Member avatars without canvas ([\element-hq#9990](matrix-org/matrix-react-sdk#9990)). Contributed by @clarkf.
* Apply more general fix for base avatar regressions ([\element-hq#10045](matrix-org/matrix-react-sdk#10045)). Fixes element-hq#24382 and element-hq#24370.
* Replace list, code block and quote icons by new icons ([\element-hq#10035](matrix-org/matrix-react-sdk#10035)). Contributed by @florianduros.
* fix regional emojis converted to flags ([\element-hq#9294](matrix-org/matrix-react-sdk#9294)). Fixes element-hq#19000. Contributed by @grimhilt.
* resolved emoji description text overflowing issue ([\element-hq#10028](matrix-org/matrix-react-sdk#10028)). Contributed by @fahadNoufal.
* Fix MessageEditHistoryDialog crashing on complex input ([\element-hq#10018](matrix-org/matrix-react-sdk#10018)). Fixes element-hq#23665. Contributed by @clarkf.
* Unify unread notification state determination ([\element-hq#9941](matrix-org/matrix-react-sdk#9941)). Contributed by @clarkf.
* Fix layout and visual regressions around default avatars ([\element-hq#10031](matrix-org/matrix-react-sdk#10031)). Fixes element-hq#24375 and element-hq#24369.
* Fix useUnreadNotifications exploding with falsey room, like in notif panel ([\element-hq#10030](matrix-org/matrix-react-sdk#10030)). Fixes matrix-org/element-web-rageshakes#19334.
* Fix "[object Promise]" appearing in HTML exports ([\element-hq#9975](matrix-org/matrix-react-sdk#9975)). Fixes element-hq#24272. Contributed by @clarkf.
* changing the color of message time stamp ([\element-hq#10016](matrix-org/matrix-react-sdk#10016)). Contributed by @nawarajshah.
* Fix link creation with backward selection ([\element-hq#9986](matrix-org/matrix-react-sdk#9986)). Fixes element-hq#24315. Contributed by @florianduros.
* Misaligned reply preview in thread composer element-hq#23396 ([\element-hq#9977](matrix-org/matrix-react-sdk#9977)). Fixes element-hq#23396. Contributed by @mustafa-kapadia1483.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 T-Defect Z-Synapse
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @turt2live @lampholder @akontsevich