Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to React 16 #10480

Merged
merged 7 commits into from
Sep 11, 2019
Merged

Switch to React 16 #10480

merged 7 commits into from
Sep 11, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 1, 2019 •
edited by turt2live
Loading

Depends on matrix-org/matrix-react-sdk#3270

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Fixes #6410 ~ Travis

@t3chguy
Switch to React 16.8
06e7a48 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy mentioned this pull request Aug 1, 2019
Merged
t3chguy added 6 commits August 6, 2019 18:22
@t3chguy
discard create-react-class, no point using it here. use React.FC
da9f1d1 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
fix VectorCustomServerDialog props
6d7c4c4 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branches 'develop' and 't3chguy/react16' of github.com:vector-i…
d347ab0 
…m/riot-web into t3chguy/react16
@t3chguy
Merge branch 'develop' of github.com:vector-im/riot-web into t3chguy/…
7eefc9d 
…react16
@t3chguy
Merge branches 'develop' and 't3chguy/react16' of github.com:vector-i…
8b1fdc6 
…m/riot-web into t3chguy/react16
@t3chguy
Switch to React 16.9
33c17a6 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@jryans jryans changed the title Switch to React 16.8 Switch to React 16 Aug 28, 2019
@t3chguy t3chguy requested a review from a team September 6, 2019 18:22
turt2live
turt2live approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm however due to a significant release in the works, I think it's best to land this after the release for maximum testing time. If all goes according to plan, we'll be releasing in about a week.

@turt2live turt2live mentioned this pull request Sep 6, 2019
Closed
turt2live
turt2live approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see see https://matrix.to/#/!DdJkzRliezrwpNebLk:matrix.org/$1568219990249171GhfVS:matrix.org?via=matrix.org&via=openintents.modular.im&via=vector.modular.im

@turt2live turt2live merged commit 0b6c29d into develop Sep 11, 2019
@t3chguy t3chguy deleted the t3chguy/react16 branch May 12, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade path to React 16
2 participants
@t3chguy @turt2live