-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation fix: missing comma and I would also take the ellipsis away #17233
Conversation
took me a while to find the mistake and "comment" and I think it'll take other even longer...
Your example is still invalid, just in a different way.
It is why it was the way it was with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
giving the code block a json5
type and putting inline comments in would be preferred.
Should I open an issue for this then? The code is invalid but it still works, what's are username colors? I'm assuming avatar background colors are the generated profile pictures? |
I think the missing comma is definitely a mistake though is it not? |
Ah 🤦 thx 😊 |
Merge queue setting changed
|
|
Skipping the CLA requirement since this was written way before the requirement was introduced |
4bb9f2e
took me a while to find the mistake and "comment" and I think it'll take other even longer...
Signed-off-by: Chagai Friedlander chagai95@gmail.com