Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fix: missing comma and I would also take the ellipsis away #17233

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

chagai95
Copy link
Contributor

took me a while to find the mistake and "comment" and I think it'll take other even longer...

Signed-off-by: Chagai Friedlander chagai95@gmail.com

took me a while to find the mistake and "comment" and I think it'll take other even longer...
@t3chguy
Copy link
Member

t3chguy commented May 10, 2021

Your example is still invalid, just in a different way.

username-colors is expected to contain 8 colors. avatar-background-colors is expected to contain 3 colors.

It is why it was the way it was with the ...

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giving the code block a json5 type and putting inline comments in would be preferred.

@chagai95
Copy link
Contributor Author

Should I open an issue for this then? The code is invalid but it still works, what's are username colors? I'm assuming avatar background colors are the generated profile pictures?

@chagai95
Copy link
Contributor Author

I think the missing comma is definitely a mistake though is it not?

@t3chguy
Copy link
Member

t3chguy commented May 11, 2021

what's are username colors?

image

@chagai95
Copy link
Contributor Author

Ah 🤦 thx 😊

@jryans jryans changed the title Missing coma and I would also take the ellipsis away Missing comma and I would also take the ellipsis away May 19, 2021
@turt2live turt2live self-requested a review January 20, 2022 23:55
@chagai95 chagai95 requested a review from a team as a code owner March 18, 2022 19:57
@turt2live turt2live enabled auto-merge (squash) March 18, 2022 19:57
auto-merge was automatically disabled January 8, 2024 12:36

Merge queue setting changed

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ turt2live
❌ chagai95
You have signed the CLA already but the status is still pending? Let us recheck it.

@richvdh richvdh changed the title Missing comma and I would also take the ellipsis away Documentation fix: missing comma and I would also take the ellipsis away Oct 24, 2024
@richvdh richvdh added the T-Task Tasks for the team like planning label Oct 24, 2024
@richvdh
Copy link
Member

richvdh commented Oct 24, 2024

Skipping the CLA requirement since this was written way before the requirement was introduced

@richvdh richvdh added this pull request to the merge queue Oct 31, 2024
Merged via the queue into element-hq:develop with commit 4bb9f2e Oct 31, 2024
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants