Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor string change in settings tab #20804

Closed
wants to merge 3 commits into from
Closed

minor string change in settings tab #20804

wants to merge 3 commits into from

Conversation

aj-ya
Copy link

@aj-ya aj-ya commented Jan 29, 2022

Fixes: #20755

Signed-off-by: Ajeya Bhat ajeyabhat.off@gmail.com

Notes:

Changed ... recently visited room or community to ... recently visited room or space


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@aj-ya aj-ya requested a review from a team as a code owner January 29, 2022 06:09
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for working on this!

@t3chguy
Copy link
Member

t3chguy commented Jan 31, 2022

You can still switch to communities in Settings, unfortunately the string should vary depending on if the user has Spaces or Communities enabled
image

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to keep this as-is until Communities are deleted, at which point we can consider the string (and fix it).

I believe the deletion is planned Soon™, though don't have an exact target date just yet.

@aj-ya
Copy link
Author

aj-ya commented Feb 21, 2022

Hey @turt2live ! If I'm not wrong, there aren't any more changes to be done to the solution right? If not, should I proceed
with the below suggestion by @t3chguy

You can still switch to communities in Settings, unfortunately, the string should vary depending on if the user has Spaces or Communities enabled image

P.S. apologies for the late reply, i thought the pr would be merged.

@luixxiul
Copy link

luixxiul commented Mar 5, 2022

It looks like this PR reinserts the shortcuts moved to react-sdk with https://github.com/matrix-org/matrix-react-sdk/pull/7850/files#diff-454f7f431b8bcf5cfe7cdb0a66bc6f123dcf9617f67d7dce3b3d99bbb1fdad64R265-R266 which was merged after this PR was created.

You could refer luixxiul/matrix-react-sdk@72fd521 if you are still interested, since I don't want to hijack the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mentions of communities from Keyboard settings tab
5 participants