Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice rooms prototype #21476

Merged
merged 7 commits into from
Mar 22, 2022
Merged

Voice rooms prototype #21476

merged 7 commits into from
Mar 22, 2022

Conversation

robintown
Copy link
Member

@robintown robintown commented Mar 18, 2022

See matrix-org/matrix-react-sdk#8084 for the full details.

Notes: none
(notes are in the react-sdk PR)


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Signed-off-by: Robin Townsend <robin@robin.town>
Signed-off-by: Robin Townsend <robin@robin.town>
Signed-off-by: Robin Townsend <robin@robin.town>
@robintown robintown requested a review from a team as a code owner March 18, 2022 18:34
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good - thanks!

src/vector/jitsi/index.ts Outdated Show resolved Hide resolved
docs/labs.md Outdated Show resolved Hide resolved
Signed-off-by: Robin Townsend <robin@robin.town>
Signed-off-by: Robin Townsend <robin@robin.town>
@robintown robintown requested a review from turt2live March 18, 2022 22:06
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this side lgtm

@turt2live
Copy link
Member

eslint be less happy though, presumably because of the js-sdk refactor.

Signed-off-by: Robin Townsend <robin@robin.town>
@turt2live turt2live merged commit 6103f4a into element-hq:develop Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants