Put a cachebuster in the names of CSS and JS files #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that clients can do better caching of assets, as it will mean we are no longer reliant on etags to ensure that clients get a fresh version. We inhibit the cachebuster for `npm start`, so that we don't get millions of copies of the bundles on dev boxes.
richvdh
force-pushed
the
rav/cache_busting
branch
from
dcaf87c
to
6396c60
Compare
dbkr
reviewed
Oct 26, 2016
|
|
||
| new HtmlWebpackPlugin({ | ||
| template: './src/vector/index.html', | ||
| inject: false, // we inject the links ourselves via the template |
There was a problem hiding this comment.
because HtmlWebpackPlugin wants to put the script tags either in or at the end of , and I was a bit scared about moving it.
|
Otherwise lgtm |
|
(please don't merge this to develop yet) |
richvdh
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Oct 26, 2016
Looks like the cachebuster stuff in element-hq/element-web#2515 broke room tinting. Add a fix, along with some ranting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that clients can do better caching of assets, as it will mean we are
no longer reliant on etags to ensure that clients get a fresh version.
We inhibit the cachebuster for
npm start, so that we don't get millions ofcopies of the bundles on dev boxes.