Fix asset path issue for "compound-design-tokens" package

[menturion]

The fix given here #26069 does not work if one clone the compound-design-tokens package separately and link it within the matrix-react-sdk, because the regex /@vector-im(?:\\|\/)compound-(.*?)(?:\\|\/)/ does not match the paths in case of a cloned & linked package due to the missing substring @vector-im, see below:

Resource paths (on Windows) are e.g. ...

• Not linked package
  resourcePath: C:\src\matrix-react-sdk\node_modules\@vector-im\compound-design-tokens\icons\chat-solid.svg

• Cloned & linked package
  resourcePath: C:\src\compound-design-tokens\icons\chat-solid.svg

Problem:
The main problem is not whether absolute vs relative paths but that the compound-design-tokens package does not have a dist or res subfolder to serve the assets so that the existing regex /^.*[/\\](dist|res)[/\\]/ does not match.

Solution:
The solution is to add the missing root folder name for the assets to the above regex, with ...
/^.*[/\](dist|res|compound-design-tokens)[/\]/

I have tested this for both scenarios (linked/not linked) on Windows and it works with the regex statement:

const prefix = /^.*[/\\](dist|res|compound-design-tokens)[/\\]/;

The full part regarding compoundImportsPrefix is in this case obsolete and can be removed in the webpack.config.js.

Signed-off-by: menturion menturion@gmail.com

---

This change is marked as an internal change (Task), so will not be included in the changelog.

[richvdh]

This looks sensible to me.

However, I'm afraid we don't accept contributions signed off under a pseudonym, per CONTRIBUTING.md, so we'll need your real name to be able to accept this.

If you prefer, you can provide this privately by emailing dco@matrix.org, though our contributing guide doesn't seem to mention this (#26654).

[menturion]

Hi Richard, many thanks for the info and your support.
I have filed the issue here #26657 which should be fixed IMHO.