Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for element call external conference configuration (single-page app URL) #27101

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Mar 1, 2024

Depends on: matrix-org/matrix-react-sdk#12259

Signed-off-by: Timo K toger5@hotmail.de

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Signed-off-by: Timo K <toger5@hotmail.de>
@toger5 toger5 force-pushed the toger5/docs-for-element-call-guest-spa branch from 8937674 to 831eddf Compare March 1, 2024 13:33
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docs for element call guest spa

Loving the idea of inviting our users for a day of baths and beauty treatments. However, maybe you mean a single-page app (SPA)?

Could you update the PR description, and also I suggest using the full term rather than the abbreviation at least the first time it is used in the documentation.

docs/config.md Outdated Show resolved Hide resolved
@toger5 toger5 changed the title Add docs for element call guest spa Add docs for element call external conference configuration (singe page app url) Mar 1, 2024
@toger5 toger5 changed the title Add docs for element call external conference configuration (singe page app url) Add docs for element call external conference configuration (single-page app URL) Mar 1, 2024
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5 toger5 requested a review from richvdh March 4, 2024 14:04
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than a couple of tweaks. Thanks for documenting things!

docs/config.md Outdated Show resolved Hide resolved
toger5 and others added 2 commits March 6, 2024 11:31
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5 toger5 added this pull request to the merge queue Mar 8, 2024
Merged via the queue into develop with commit a0c90f9 Mar 8, 2024
30 checks passed
@toger5 toger5 deleted the toger5/docs-for-element-call-guest-spa branch March 8, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants