Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for widget container height option #27922

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Aug 15, 2024

See matrix-org/matrix-react-sdk#12893

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@dbkr dbkr marked this pull request as ready for review August 15, 2024 14:11
@dbkr dbkr requested a review from a team as a code owner August 15, 2024 14:11
@dbkr dbkr requested review from t3chguy and MidhunSureshR August 15, 2024 14:11

- `default_widget_container_height`

This controls the height that the top widget panel initially appears as and is the height in pixels, default 280.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the value in the config sample, is the default 280 or 280px?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good spot, thanks

@dbkr dbkr requested a review from t3chguy August 16, 2024 08:41
@dbkr dbkr added this pull request to the merge queue Aug 27, 2024
Merged via the queue into develop with commit 8805220 Aug 27, 2024
25 checks passed
@dbkr dbkr deleted the dbkr/apps_drawer_height_option branch August 27, 2024 10:38
@@ -22,6 +22,7 @@
"https://scalar-staging.vector.im/api",
"https://scalar-staging.riot.im/scalar/api"
],
"default_widget_height": 280,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key seems to have the wrong name, since the documentation and implementation both use default_widget_container_height instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, good spot, although the correct way to report these is by filing bugs. In general, people won't be looking at old, closed PRs unless they happen to see it in notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants