Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise icons using Compound Design Tokens #28217

Merged
merged 32 commits into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
773b93e
De-duplicate icons using Compound Design Tokens
t3chguy Jul 22, 2024
dc20c2c
delint
t3chguy Jul 22, 2024
aeb9db3
Iterate
t3chguy Jul 22, 2024
9aa7732
Iterate
t3chguy Jul 22, 2024
65bfbb4
Iterate
t3chguy Jul 22, 2024
c887a6f
Iterate
t3chguy Jul 22, 2024
d85d400
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
t3chguy Jul 22, 2024
2ccac7f
Merge branch 'develop' of github.com:element-hq/matrix-react-sdk into…
t3chguy Oct 4, 2024
82d9e92
Merge branch 'develop' of github.com:element-hq/matrix-react-sdk into…
t3chguy Oct 4, 2024
1bfaa78
Merge branch 'develop' into t3chguy/dedup-icons
t3chguy Oct 8, 2024
73c7a77
Merge branch 'develop' of github.com:element-hq/matrix-react-sdk into…
t3chguy Oct 8, 2024
258ebe4
Deduplicate more icons using Compound Design Tokens
t3chguy Oct 8, 2024
bcd5806
Iterate
t3chguy Oct 8, 2024
c302785
Merge branch 'develop' into t3chguy/dedup-icons
t3chguy Oct 14, 2024
6da8e43
Merge branch 't3chguy/dedup-icons-generic' of github.com:element-hq/m…
t3chguy Oct 14, 2024
498e8ba
Merge branch 'develop' into t3chguy/dedup-icons-generic
t3chguy Oct 14, 2024
5660d50
Merge branch 't3chguy/dedup-icons-generic' of github.com:element-hq/m…
t3chguy Oct 14, 2024
f760a5b
Merge branch 't3chguy/dedup-icons' of ../matrix-react-sdk into t3chgu…
t3chguy Oct 17, 2024
e9e66cc
Merge branch 'develop' of https://github.com/vector-im/element-web in…
t3chguy Oct 17, 2024
a71134d
Merge branch 'develop' of https://github.com/vector-im/element-web in…
t3chguy Oct 18, 2024
f685c95
Merge branch 'develop' of https://github.com/vector-im/element-web in…
t3chguy Oct 24, 2024
b4f3a88
Merge branch 'develop' of https://github.com/vector-im/element-web in…
t3chguy Nov 18, 2024
d9653bb
Update icon
t3chguy Nov 18, 2024
027e304
Discard changes to res/css/structures/_RoomSearch.pcss
t3chguy Nov 18, 2024
18ed9fa
Update snapshots
t3chguy Nov 18, 2024
9fd8331
Merge remote-tracking branch 'origin/t3chguy/dedup-icons-17oct' into …
t3chguy Nov 18, 2024
9d98aca
Iterate
t3chguy Nov 18, 2024
a18c910
Iterate
t3chguy Nov 18, 2024
1dc3aab
Discard changes to res/fonts/Open_Sans/LICENSE.txt
t3chguy Nov 18, 2024
e9b4437
Discard changes to res/css/views/elements/_CopyableText.pcss
t3chguy Nov 18, 2024
8d11baa
Iterate
t3chguy Nov 18, 2024
33796c4
Merge remote-tracking branch 'origin/t3chguy/dedup-icons-17oct' into …
t3chguy Nov 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions res/css/structures/_RightPanel.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Please see LICENSE files in the repository root for full details.
/** Fixme - factor this out with the main header **/

.mx_RightPanel_threadsButton::before {
mask-image: url("$(res)/img/element-icons/room/thread.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/threads-solid.svg");
}

.mx_RightPanel_notifsButton::before {
Expand All @@ -36,7 +36,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_RightPanel_roomSummaryButton::before {
mask-image: url("$(res)/img/element-icons/room/room-summary.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/info-solid.svg");
mask-position: center;
}

Expand Down
8 changes: 4 additions & 4 deletions res/css/structures/_SpacePanel.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -211,11 +211,11 @@ Please see LICENSE files in the repository root for full details.
}

&.mx_SpaceButton_favourites .mx_SpaceButton_icon::before {
mask-image: url("$(res)/img/element-icons/roomlist/favorite.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/favourite-solid.svg");
}

&.mx_SpaceButton_people .mx_SpaceButton_icon::before {
mask-image: url("$(res)/img/element-icons/room/members.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/user-profile-solid.svg");
}

&.mx_SpaceButton_orphans .mx_SpaceButton_icon::before {
Expand Down Expand Up @@ -426,11 +426,11 @@ Please see LICENSE files in the repository root for full details.
}

.mx_SpacePanel_iconLeave::before {
mask-image: url("$(res)/img/element-icons/leave.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/leave.svg");
}

.mx_SpacePanel_iconMembers::before {
mask-image: url("$(res)/img/element-icons/room/members.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/user-profile-solid.svg");
}

.mx_SpacePanel_iconPlus::before {
Expand Down
2 changes: 1 addition & 1 deletion res/css/structures/_SpaceRoomView.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_SpaceRoomView_privateScope_justMeButton::before {
mask-image: url("$(res)/img/element-icons/room/members.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/user-profile-solid.svg");
}

.mx_SpaceRoomView_privateScope_meAndMyTeammatesButton::before {
Expand Down
2 changes: 1 addition & 1 deletion res/css/structures/_UserMenu.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_UserMenu_iconSignOut::before {
mask-image: url("$(res)/img/element-icons/leave.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/leave.svg");
}

.mx_UserMenu_iconQr::before {
Expand Down
6 changes: 3 additions & 3 deletions res/css/views/context_menus/_MessageContextMenu.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_MessageContextMenu_iconLink::before {
mask-image: url("$(res)/img/element-icons/link.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/link.svg");
}

.mx_MessageContextMenu_iconPermalink::before {
Expand All @@ -53,7 +53,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_MessageContextMenu_iconForward::before {
mask-image: url("$(res)/img/element-icons/message/fwd.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/forward.svg");
}

.mx_MessageContextMenu_iconRedact::before {
Expand Down Expand Up @@ -96,7 +96,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_MessageContextMenu_iconReplyInThread::before {
mask-image: url("$(res)/img/element-icons/message/thread.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/threads.svg");
}

.mx_MessageContextMenu_iconReact::before {
Expand Down
12 changes: 6 additions & 6 deletions res/css/views/context_menus/_RoomGeneralContextMenu.pcss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.mx_RoomGeneralContextMenu_iconStar::before {
mask-image: url("$(res)/img/element-icons/roomlist/favorite.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/favourite-solid.svg");
}

.mx_RoomGeneralContextMenu_iconArrowDown::before {
Expand Down Expand Up @@ -31,7 +31,7 @@
}

.mx_RoomGeneralContextMenu_iconPeople::before {
mask-image: url("$(res)/img/element-icons/room/members.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/user-profile-solid.svg");
}

.mx_RoomGeneralContextMenu_iconFiles::before {
Expand All @@ -43,29 +43,29 @@
}

.mx_RoomGeneralContextMenu_iconWidgets::before {
mask-image: url("$(res)/img/element-icons/room/apps.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/extensions-solid.svg");
}

.mx_RoomGeneralContextMenu_iconSettings::before {
mask-image: url("@vector-im/compound-design-tokens/icons/settings-solid.svg");
}

.mx_RoomGeneralContextMenu_iconExport::before {
mask-image: url("$(res)/img/element-icons/export.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/export-archive.svg");
}

.mx_RoomGeneralContextMenu_iconDeveloperTools::before {
mask-image: url("$(res)/img/element-icons/settings/flask.svg");
}

.mx_RoomGeneralContextMenu_iconCopyLink::before {
mask-image: url("$(res)/img/element-icons/link.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/link.svg");
}

.mx_RoomGeneralContextMenu_iconInvite::before {
mask-image: url("$(res)/img/element-icons/room/invite.svg");
}

.mx_RoomGeneralContextMenu_iconSignOut::before {
mask-image: url("$(res)/img/element-icons/leave.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/leave.svg");
}
2 changes: 1 addition & 1 deletion res/css/views/dialogs/_ConfirmSpaceUserActionDialog.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Please see LICENSE files in the repository root for full details.
background-color: $secondary-content;
mask-repeat: no-repeat;
mask-size: contain;
mask-image: url("$(res)/img/element-icons/room/room-summary.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/info-solid.svg");
mask-position: center;
}
}
Expand Down
2 changes: 1 addition & 1 deletion res/css/views/dialogs/_LeaveSpaceDialog.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Please see LICENSE files in the repository root for full details.
background-color: $secondary-content;
mask-repeat: no-repeat;
mask-size: contain;
mask-image: url("$(res)/img/element-icons/room/room-summary.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/info-solid.svg");
mask-position: center;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ Please see LICENSE files in the repository root for full details.
background-color: $secondary-content;
mask-repeat: no-repeat;
mask-size: contain;
mask-image: url("$(res)/img/element-icons/room/room-summary.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/info-solid.svg");
mask-position: center;
}
}
Expand Down
10 changes: 5 additions & 5 deletions res/css/views/dialogs/_SpotlightDialog.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Please see LICENSE files in the repository root for full details.
}

&.mx_SpotlightDialog_filterPeople::before {
mask-image: url("$(res)/img/element-icons/room/members.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/user-profile-solid.svg");
}

&.mx_SpotlightDialog_filterPublicRooms::before {
Expand Down Expand Up @@ -400,7 +400,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_SpotlightDialog_inviteLink .mx_AccessibleButton::before {
mask-image: url("$(res)/img/element-icons/link.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/link.svg");
}

.mx_SpotlightDialog_createRoom .mx_AccessibleButton::before {
Expand Down Expand Up @@ -432,7 +432,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_SpotlightDialog_startChat::before {
mask-image: url("$(res)/img/element-icons/room/members.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/user-profile-solid.svg");
}

.mx_SpotlightDialog_joinRoomAlias::before {
Expand Down Expand Up @@ -512,11 +512,11 @@ Please see LICENSE files in the repository root for full details.
}

&.mx_SpotlightDialog_metaspaceResult_favourites-space {
mask-image: url("$(res)/img/element-icons/roomlist/favorite.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/favourite-solid.svg");
}

&.mx_SpotlightDialog_metaspaceResult_people-space {
mask-image: url("$(res)/img/element-icons/room/members.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/user-profile-solid.svg");
}

&.mx_SpotlightDialog_metaspaceResult_orphans-space {
Expand Down
2 changes: 1 addition & 1 deletion res/css/views/elements/_InfoTooltip.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_InfoTooltip_icon_info::before {
mask-image: url("$(res)/img/element-icons/info.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/info.svg");
}

.mx_InfoTooltip_icon_warning::before {
Expand Down
4 changes: 4 additions & 0 deletions res/css/views/messages/_MessageActionBar.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ Please see LICENSE files in the repository root for full details.
color: var(--cpd-color-icon-primary);
}

&.mx_MessageActionBar_threadButton {
--MessageActionBar-icon-size: 20px;
}

&.mx_MessageActionBar_retryButton {
--MessageActionBar-icon-size: 16px;
}
Expand Down
2 changes: 1 addition & 1 deletion res/css/views/right_panel/_ThreadPanel.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_ThreadPanel_copyLinkToThread::before {
mask-image: url("$(res)/img/element-icons/link.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/link.svg");
}

.mx_ContextualMenu_wrapper {
Expand Down
2 changes: 1 addition & 1 deletion res/css/views/rooms/_RoomList.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Please see LICENSE files in the repository root for full details.
mask-image: url("$(res)/img/element-icons/roomlist/dialpad.svg");
}
.mx_RoomList_iconStartChat::before {
mask-image: url("$(res)/img/element-icons/roomlist/member-plus.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/user-add-solid.svg");
}
.mx_RoomList_iconInvite::before {
mask-image: url("$(res)/img/element-icons/room/share.svg");
Expand Down
2 changes: 1 addition & 1 deletion res/css/views/rooms/_RoomListHeader.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ Please see LICENSE files in the repository root for full details.
mask-image: url("$(res)/img/element-icons/room/invite.svg");
}
.mx_RoomListHeader_iconStartChat::before {
mask-image: url("$(res)/img/element-icons/roomlist/member-plus.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/user-add-solid.svg");
}
.mx_RoomListHeader_iconNewRoom::before {
mask-image: url("$(res)/img/element-icons/roomlist/hash-plus.svg");
Expand Down
2 changes: 1 addition & 1 deletion res/css/views/rooms/_RoomPreviewCard.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Please see LICENSE files in the repository root for full details.
mask-repeat: no-repeat;
mask-position: center;
mask-size: contain;
mask-image: url("$(res)/img/element-icons/room/room-summary.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/info-solid.svg");
background-color: $secondary-content;
}
}
Expand Down
12 changes: 6 additions & 6 deletions res/css/views/rooms/_RoomTile.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ Please see LICENSE files in the repository root for full details.

.mx_RoomTile_contextMenu {
.mx_RoomTile_iconStar::before {
mask-image: url("$(res)/img/element-icons/roomlist/favorite.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/favourite-solid.svg");
}

.mx_RoomTile_iconArrowDown::before {
Expand All @@ -206,7 +206,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_RoomTile_iconPeople::before {
mask-image: url("$(res)/img/element-icons/room/members.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/user-profile-solid.svg");
}

.mx_RoomTile_iconFiles::before {
Expand All @@ -218,26 +218,26 @@ Please see LICENSE files in the repository root for full details.
}

.mx_RoomTile_iconWidgets::before {
mask-image: url("$(res)/img/element-icons/room/apps.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/extensions-solid.svg");
}

.mx_RoomTile_iconSettings::before {
mask-image: url("@vector-im/compound-design-tokens/icons/settings-solid.svg");
}

.mx_RoomTile_iconExport::before {
mask-image: url("$(res)/img/element-icons/export.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/export-archive.svg");
}

.mx_RoomTile_iconCopyLink::before {
mask-image: url("$(res)/img/element-icons/link.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/link.svg");
}

.mx_RoomTile_iconInvite::before {
mask-image: url("$(res)/img/element-icons/room/invite.svg");
}

.mx_RoomTile_iconSignOut::before {
mask-image: url("$(res)/img/element-icons/leave.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/leave.svg");
}
}
2 changes: 1 addition & 1 deletion res/css/views/spaces/_SpacePublicShare.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Please see LICENSE files in the repository root for full details.
@mixin SpacePillButton;

&.mx_SpacePublicShare_shareButton::before {
mask-image: url("$(res)/img/element-icons/link.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/link.svg");
}

&.mx_SpacePublicShare_inviteButton::before {
Expand Down
8 changes: 0 additions & 8 deletions res/img/element-icons/export.svg

This file was deleted.

4 changes: 0 additions & 4 deletions res/img/element-icons/info.svg

This file was deleted.

7 changes: 0 additions & 7 deletions res/img/element-icons/leave.svg

This file was deleted.

3 changes: 0 additions & 3 deletions res/img/element-icons/link.svg

This file was deleted.

3 changes: 0 additions & 3 deletions res/img/element-icons/location.svg

This file was deleted.

3 changes: 0 additions & 3 deletions res/img/element-icons/message/fwd.svg

This file was deleted.

1 change: 0 additions & 1 deletion res/img/element-icons/message/thread.svg

This file was deleted.

6 changes: 0 additions & 6 deletions res/img/element-icons/room/apps.svg

This file was deleted.

Loading
Loading