Fix React 18 strict mode breaking spotlight dialog #28452
Merged
+270
−212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code originally held an array of refs. But these refs were unset just before sorting leading to errors. For the fix, I've used a callback ref to add/remove the DOM elements to/from the array in state. This way there's nothing that could possibly mutate just before sort.
t3chguy
reviewed
Nov 12, 2024
t3chguy
reviewed
Nov 12, 2024
t3chguy
reviewed
Nov 13, 2024
t3chguy
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28404
Previously
RovingTabIndexProviderheld an array of refs in state. Every time a new ref was added to the array, the entire array was sorted. With strict mode, refs/reducers/components/effects are all run twice. This lead to some refs being unset (i.e ref.current = null) just before sorting began.This PR fixes the issue by refactoring the code so that we keep an array of DOM elements instead of refs.