Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matrix-widget-api version in package.json #28453

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

AndrewFerr
Copy link
Member

matrix-js-sdk#develop now depends on matrix-widget-api^v1.10.0, so update the lockfile to match that. A yarn install would update the lockfile otherwise.

The correct version was reverted by #28430.

Signed-off-by: Andrew Ferrazzutti andrewf@element.io

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@MidhunSureshR
Copy link
Member

MidhunSureshR commented Nov 15, 2024

I'm a bit confused here; are you saying that if I git pull develop and do yarn install, yarn.lock would get updated?

@AndrewFerr
Copy link
Member Author

I'm a bit confused here; are you saying that if I git pull develop and do yarn install, yarn.lock would get updated?

Yes, exactly.

@MidhunSureshR
Copy link
Member

That doesn't happen for me. Also the CI would have failed if yarn.lock was modified?

matrix-js-sdk#develop now depends on matrix-widget-api^v1.10.0, so
update the lockfile to match that.
@AndrewFerr
Copy link
Member Author

Interesting, the lockfile was getting updated for me when I filed this, but not anymore. I updated the commit message to reflect that.

I'm not sure if CI fails on lockfiles getting modified, but workflows do tend to use yarn install --frozen-lockfile if that helps.

Copy link
Member

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MidhunSureshR MidhunSureshR added this pull request to the merge queue Nov 15, 2024
Merged via the queue into element-hq:develop with commit 28640ee Nov 15, 2024
29 checks passed
@AndrewFerr AndrewFerr deleted the widget-api-version branch November 15, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants