Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Features.RustCrypto flag #28582

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Remove Features.RustCrypto flag #28582

merged 2 commits into from
Nov 27, 2024
+0 −29

Conversation

florianduros
Copy link
Member

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@florianduros florianduros force-pushed the florianduros/remove-rust-crypto-flag branch from ef271ba to 888f762 Compare November 27, 2024 14:57
@florianduros florianduros force-pushed the florianduros/remove-rust-crypto-flag branch from 888f762 to 4fe9486 Compare November 27, 2024 15:06
t3chguy
t3chguy reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could of tests still reference feature_rust_crypto

@florianduros
Copy link
Member Author

@t3chguy I removed the check of feature_rust_crypto

@florianduros florianduros marked this pull request as ready for review November 27, 2024 15:18
@florianduros florianduros requested a review from a team as a code owner November 27, 2024 15:18
@florianduros florianduros added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@florianduros florianduros added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit 08418c1 Nov 27, 2024
32 checks passed
@florianduros florianduros deleted the florianduros/remove-rust-crypto-flag branch November 27, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @t3chguy