Enable key backup by default #28691
Merged
Enable key backup by default #28691
+162
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make components pure and avoid react 18 dev mode problems due to components making requests when mounted.
When we set up cross signing, so the key backup key will be stored locally along with the cross signing keys until the user sets up recovery (4s). This will mean that a user can restore their backup if they log in on a new device as long as they verify with the one they registered on. Replaces #28267
MidhunSureshR
approved these changes
Dec 16, 2024
| logger.log("uploadDeviceSigningKeys unexpectedly succeeded without UI auth!"); | ||
| return false; | ||
| return true; |
There was a problem hiding this comment.
This is the meat of the PR no?
There was a problem hiding this comment.
Not really: this actually worked before by going through the UIA flow which just worked because it didn't actually need UIA. That fails in dev mode now though. Fortunately, it was a bug that we were going via the UIA flow anyway.
|
Unfortunately the toast and backup by default change depended on one another, so couldn't really be split out. That just left the one-line fix for uploading keys, which I could have split out but didn't bother as I'd already split out quite a few other bits. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we set up cross signing, so the key backup key will be stored locally along with the cross signing keys until the user sets up recovery (4s). This will mean that a user can restore their backup if they log in on a new device as long as they verify with the one they registered on.
Replaces #28267
Checklist
public/exportedsymbols have accurate TSDoc documentation.