Implement PasswordNagBar #3817
Merged
Implement PasswordNagBar #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will tell the user that they need to set a password to return to their account.
dbkr
reviewed
May 5, 2017
| const AccessibleButton = sdk.getComponent('elements.AccessibleButton'); | ||
| return ( | ||
| <div className="mx_MatrixToolbar"> | ||
| <img className="mx_MatrixToolbar_warning" src="img/warning.svg" width="24" height="23" alt="/!\"/> |
There was a problem hiding this comment.
I think you want two backslashes at the end here (as this is an escaped double quote) (and yes, it was probably wrong in wherever you copied it from) (or possibly replace it with something more screenreader-friendly than, "forward slash, exclamation mark, backslash")
src/component-index.js
Outdated
| @@ -19,9 +20,6 @@ limitations under the License. | |||
| * You can edit it you like, but your changes will be overwritten, | |||
| * so you'd just be trying to swim upstream like a salmon. | |||
| * You are not a salmon. | |||
| * | |||
| * To update it, run: | |||
| * ./reskindex.js -h header | |||
added 2 commits
May 8, 2017 10:01
dbkr
approved these changes
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will tell the user that they need to set a password to return to their account.
Part of #3602