Split MImageBody into MFileBody to match JS Classes. #6067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
commented
Jan 30, 2018
| .mx_MFileBody_download a { | ||
| color: $accent-color; | ||
| text-decoration: none; | ||
| cursor: pointer; |
There was a problem hiding this comment.
I should have done the file splitting and the adding of the new css in two commits - sorry
AAAAAAnyway, the above line is the only one added
|
This looks good, but could you split the commit up as you said, @t3chguy |
and having the classnames match their components. Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
force-pushed
the
t3chguy/fix_usercontent_pointer
branch
from
1225ba0
to
3abf145
Compare
|
@lukebarnard1 split |
lukebarnard1
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit cursor:pointer so calculated CSS includes it for
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com
Copyright left unchanged as the majority is split out of MImageBody
Twinned with matrix-org/matrix-react-sdk#1726
Fixes #6058