Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start documenting keyboard shortcuts #7165

Merged
merged 2 commits into from
Jan 10, 2019
Merged

Start documenting keyboard shortcuts #7165

merged 2 commits into from
Jan 10, 2019

Conversation

ptman
Copy link
Contributor

@ptman ptman commented Aug 14, 2018

I'm sure I don't know all of them.

@@ -0,0 +1,9 @@
# Keyboard Shortcuts

- <kbd>Ctrl</kbd>+<kbd>m</kbd> - toggle markdown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are actually Control or Command depending on whether you're not on a Mac

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of them or just this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better?

@aaronraimist
Copy link
Collaborator

Looks good to me

@t3chguy?

@aaronraimist aaronraimist mentioned this pull request Nov 25, 2018
2 tasks
@ptman ptman mentioned this pull request Jan 3, 2019
6 tasks
@jryans jryans requested a review from a team January 4, 2019 16:14
@jryans
Copy link
Collaborator

jryans commented Jan 4, 2019

Thanks for making this contribution a while back. It looks like this one fell through the cracks a bit. I have added it to the review queue, so hopefully we'll get a fresh look at it soon.

@ptman
Copy link
Contributor Author

ptman commented Jan 4, 2019

@jryans no worries, I get it that you have a huge load of issues and PRs

@jryans
Copy link
Collaborator

jryans commented Jan 8, 2019

I think it would be fine to land this as-is. We can always update or extend it later.

@ptman Please update the PR or each commit with your sign off as described in CONTRIBUTING.rst. We should be able to merge this once that's done.

I'm sure I don't know all of them.

Signed-off-by: Paul Tötterman <paul.totterman@iki.fi>
Signed-off-by: Paul Tötterman <paul.totterman@iki.fi>
@jryans jryans self-assigned this Jan 10, 2019
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 😁 I am sure there are more to list, but we can always add those at any time.

@jryans jryans dismissed t3chguy’s stale review January 10, 2019 15:22

Outdated review

@jryans
Copy link
Collaborator

jryans commented Jan 10, 2019

I am assuming the test failures in CI are unrelated since there are no code changes here.

@jryans jryans merged commit 3d7a74c into element-hq:master Jan 10, 2019
@jryans jryans removed their assignment Jan 10, 2019
@ptman ptman deleted the patch-1 branch January 10, 2019 15:24
@ptman
Copy link
Contributor Author

ptman commented Jan 10, 2019

Yes, I certainly hope there are more, but those were the only ones I could find when I wrote this. Would especially like a shortcut to switch to the next unread room.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants