Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate platform electron build commands #9412

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Add separate platform electron build commands #9412

merged 3 commits into from
Apr 11, 2019

Conversation

anoadragon453
Copy link
Member

Add commands for building separate electron builds for each platform.

Adapted from #8397

@anoadragon453
Add separate platform electron build commands
657397b 
Add commands for building separate electron builds for each platform
@anoadragon453 anoadragon453 mentioned this pull request Apr 9, 2019
Closed
jryans
jryans reviewed Apr 9, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 requested a review from jryans April 10, 2019 16:52
jryans
jryans approved these changes Apr 11, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks reasonable to me! 😁

@jryans jryans merged commit d187a43 into develop Apr 11, 2019
@anoadragon453
Copy link
Member Author

Oh whoops, not used to doing this for repos I'm not on. Thanks!

@t3chguy t3chguy deleted the anoa/electron_platform_builds branch May 12, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoadragon453 @jryans