Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSC4027 (Custom images in reactions) #2160

Merged
merged 13 commits into from
Jan 4, 2024

Conversation

surakin
Copy link
Contributor

@surakin surakin commented Jan 4, 2024

Fixes #2159

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Implement rendering of custom images in reaction per MSC4027

Motivation and context

Ran into mxc reactions while testing Element X and wanted to make it work

Screenshots / GIFs

image

Tests

  • Send custom reaction using Cinny
  • Observe the reaction showing up in Element X

Tested devices

  • Physical
  • Emulator
  • OS version(s):
    Android 6, 13, 14

Checklist

Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
@surakin surakin requested a review from a team as a code owner January 4, 2024 07:31
@surakin surakin requested review from jmartinesp and removed request for a team January 4, 2024 07:31
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working quite well, thanks! There are a couple of issues that should be fixed before it's merged, though.

surakin and others added 4 commits January 4, 2024 09:20
move emoji line height to a private value

Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (c2a7b38) 66.97% compared to head (5cf4dc8) 66.95%.

Files Patch % Lines
...impl/timeline/components/MessagesReactionButton.kt 58.82% 6 Missing and 1 partial ⚠️
.../components/reactionsummary/ReactionSummaryView.kt 53.33% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2160      +/-   ##
===========================================
- Coverage    66.97%   66.95%   -0.03%     
===========================================
  Files         1375     1375              
  Lines        34219    34236      +17     
  Branches      7544     7546       +2     
===========================================
+ Hits         22919    22922       +3     
- Misses        7663     7675      +12     
- Partials      3637     3639       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Jan 4, 2024
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM! You might need to add an empty commit at the end so the CI runs again (stupid GH limitations for PRs coming from forks & CI-generated commits, sigh).

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @surakin !
Can I ask you to add a comment on this PR with screenshot with the 2 rendering using the latest code:

  • timeline message with mxc reaction
  • bottom sheet of the details of this image.

Thanks!

@surakin
Copy link
Contributor Author

surakin commented Jan 4, 2024

Custom reaction
image
Bottom sheet
image

@bmarty bmarty merged commit f5a229d into element-hq:develop Jan 4, 2024
10 of 13 checks passed
@surakin surakin deleted the msc4027 branch January 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MSC4027 (Custom Images in Reactions)
3 participants