Compound: add BigIcon, BigCheckmark and PageTitle components
#2574
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2574 +/- ##
===========================================
+ Coverage 73.16% 73.19% +0.02%
===========================================
Files 1410 1413 +3
Lines 34202 34291 +89
Branches 6638 6670 +32
===========================================
+ Hits 25024 25098 +74
- Misses 5713 5718 +5
- Partials 3465 3475 +10 ☔ View full report in Codecov by Sentry. |
| ) { | ||
| val backgroundColor = when (style) { | ||
| is Style.Default -> ElementTheme.colors.bigIconDefaultBackgroundColor | ||
| Style.AlertSolid, Style.SuccessSolid -> ElementTheme.colors.bgCanvasDefault |
There was a problem hiding this comment.
I am wondering if using a transparent color should be preferable in this case. I let you decide.
There was a problem hiding this comment.
Transparent is probably better, although it kind of contradicts its name. I'm asking in the Compound room to clarify this.
There was a problem hiding this comment.
I just confirmed it with them, it's the other way around: the solid ones should have a solid background (duh), the others should be transparent. I'll change those.
| internal class BigIconStylePreviewProvider : PreviewParameterProvider<BigIcon.Style> { | ||
| override val values: Sequence<BigIcon.Style> | ||
| get() = sequenceOf( | ||
| BigIcon.Style.Default(Icons.Filled.CatchingPokemon), |
Make the non-solid ones use a transparent one.
jmartinesp
added
the
Record-Screenshots
github-actions
bot
removed
the
Record-Screenshots
|
Type of change
Content
Adds 3 new Compound components that will be needed for future development:
Motivation and context
These components will be used in new designs and will replace older ones we were using.
Screenshots / GIFs
Being recorded.
Tests
Nothing, but you can check the screenshots look like the designs in Figma.
Tested devices
Checklist