Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorise members by role in the ChangeRoles screen #2595

Merged

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Mar 22, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : UI change.

Content

  • Categorises members in different sections by role in the change roles screens.
  • For the change role to moderator screen, also add a subtitle notice confirming administrators already have moderator permissions.
  • For users who have been invited to the room, add a 'Pending' label next to their names.
  • Automatically reload member list when power levels or membership of members change.
  • Replace empty space next to users whose level can't be changed to disabled checkboxes to match the latest Figma designs.

Motivation and context

Fixes #2593 .

Screenshots / GIFs

Before After

Tests

  • Go into a room where you're an admin.
  • Open its settings -> roles and permissions -> roles (admins or moderators).
  • Verify the new design is used and the feature works.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

Copy link
Contributor

github-actions bot commented Mar 22, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/PAqxP9

@jmartinesp jmartinesp force-pushed the fix/2593-categorise-members-by-role-in-change-roles-screen branch from 971bc99 to 1cd668a Compare April 1, 2024 11:53
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 88.13559% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 73.53%. Comparing base (d5a5aaf) to head (1cc67e5).
Report is 1 commits behind head on develop.

Files Patch % Lines
...rolesandpermissions/changeroles/ChangeRolesView.kt 84.44% 3 Missing and 11 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2595      +/-   ##
===========================================
+ Coverage    73.48%   73.53%   +0.04%     
===========================================
  Files         1456     1456              
  Lines        35113    35192      +79     
  Branches      6733     6755      +22     
===========================================
+ Hits         25804    25879      +75     
+ Misses        5793     5790       -3     
- Partials      3516     3523       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp force-pushed the fix/2593-categorise-members-by-role-in-change-roles-screen branch from c0df770 to 7c6e975 Compare April 1, 2024 14:21
@jmartinesp jmartinesp marked this pull request as ready for review April 5, 2024 13:44
@jmartinesp jmartinesp requested a review from a team as a code owner April 5, 2024 13:44
@jmartinesp jmartinesp requested review from ganfra and removed request for a team April 5, 2024 13:44
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmartinesp jmartinesp added Run-Maestro Starts a Maestro Cloud session to run integration tests and removed Run-Maestro Starts a Maestro Cloud session to run integration tests labels Apr 8, 2024
@jmartinesp jmartinesp force-pushed the fix/2593-categorise-members-by-role-in-change-roles-screen branch from cdf45f3 to 94b9483 Compare April 8, 2024 08:25
@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 8, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 8, 2024
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jmartinesp jmartinesp enabled auto-merge (squash) April 8, 2024 08:50
@jmartinesp jmartinesp merged commit 8e2f7a3 into develop Apr 8, 2024
19 checks passed
@jmartinesp jmartinesp deleted the fix/2593-categorise-members-by-role-in-change-roles-screen branch April 8, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorise members by role in the ChangeRoles screen
2 participants