-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move attachment preview above the composer, allowing to add captions … #2600
Conversation
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
Is it necessary to keep the |
I understand this is the only feedback until matrix-org/matrix-rust-sdk#1732 is sorted out |
A small bug I noticed today: Trying to send a captioned image as a reply sends okay, but doesn't attach the reply metadata to the event and leaves the reply box in the composer |
Hmmm sending replies with anything other than text is not supported yet anyway |
In what sense? I have seen many users (especially beeper users) send images in reply to messages and they get rendered in EXA just fine, is there a limitation on the Rust-SDK's end maybe? 🤔 |
Yes, afaik the rust SDK can only reply with text so far. |
651a652
to
c4b5a92
Compare
I just realised that you can't edit captions with this after I typo'd one today |
a62b48c
to
bfd32a4
Compare
c49b994
to
db19262
Compare
f47d6c0
to
0cbae27
Compare
0cbae27
to
acce58e
Compare
…to media/attachments Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
acce58e
to
2a5a5a0
Compare
Thanks for the proposal. We will work very soon on this part, and it will be possible to add a caption (and do other actions on the media), in the preview screen. |
…to media/attachments
Fixes #2573
I has too many UX changes for my taste so if one of the team likes it and wants to pick it up that's fine by me :)
Type of change
Content
Motivation and context
Screenshots / GIFs
Before sending
After sending
Tests
Tested devices
Checklist