-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UI for notification permission screen in onboarding #2660
Improve UI for notification permission screen in onboarding #2660
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2660 +/- ##
===========================================
+ Coverage 73.48% 73.50% +0.01%
===========================================
Files 1456 1457 +1
Lines 35113 35142 +29
Branches 6733 6735 +2
===========================================
+ Hits 25804 25832 +28
Misses 5793 5793
- Partials 3516 3517 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not checked the figma, so I don't know if paddings are ok but otherwise LGTM
c7fbe58
to
751c481
Compare
Quality Gate passedIssues Measures |
Type of change
Content
OnboardingBackground
component.background
slot toHeaderFooterPage
.Motivation and context
Closes #2581.
Screenshots / GIFs
Tests
On an Android 13+ device:
Tested devices
Checklist