Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI for notification permission screen in onboarding #2660

Merged

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : improve UI.

Content

  • Add OnboardingBackground component.
  • Add background slot to HeaderFooterPage.
  • Make the notification opt-in screen follow the latest Figma designs.

Motivation and context

Closes #2581.

Screenshots / GIFs

Before After

Tests

On an Android 13+ device:

  • Log into an account.
  • Go through the verification step.
  • Check the new notification screen.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner April 4, 2024 16:05
@jmartinesp jmartinesp requested review from ganfra and removed request for a team April 4, 2024 16:05
Copy link
Contributor

github-actions bot commented Apr 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/QkKduv

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.50%. Comparing base (192a1d2) to head (751c481).
Report is 1 commits behind head on develop.

Files Patch % Lines
...c/main/kotlin/io/element/android/x/MainActivity.kt 0.00% 1 Missing ⚠️
.../ftue/impl/notifications/NotificationsOptInView.kt 75.00% 0 Missing and 1 partial ⚠️
...ries/designsystem/atomic/pages/HeaderFooterPage.kt 92.30% 0 Missing and 1 partial ⚠️
...es/designsystem/components/OnboardingBackground.kt 96.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2660      +/-   ##
===========================================
+ Coverage    73.48%   73.50%   +0.01%     
===========================================
  Files         1456     1457       +1     
  Lines        35113    35142      +29     
  Branches      6733     6735       +2     
===========================================
+ Hits         25804    25832      +28     
  Misses        5793     5793              
- Partials      3516     3517       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not checked the figma, so I don't know if paddings are ok but otherwise LGTM

@jmartinesp jmartinesp force-pushed the misc/jme/2581-push-notification-permissions-screen branch from c7fbe58 to 751c481 Compare April 8, 2024 08:37
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jmartinesp jmartinesp merged commit b6ceb8c into develop Apr 8, 2024
16 checks passed
@jmartinesp jmartinesp deleted the misc/jme/2581-push-notification-permissions-screen branch April 8, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] FTUE - Push notification permissions screen
2 participants