Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black-on-black status bars with hidden media #3611

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

frebib
Copy link
Contributor

@frebib frebib commented Oct 5, 2024

Content

In dark mode, the ElementTheme composable incorrectly applied a dark colour to the status bars, which was nearly invisible on top of the black background of the app.

Motivation and context

Regression fix for #3592

Screenshots / GIFs

Fixes this:

qJovVUcIzeiwxhVmTSWnRBnu

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

In dark mode, the ElementTheme composable incorrectly applied a dark
colour to the status bars, which was nearly invisible on top of the
black background of the app.

Signed-off-by: Joe Groocock <me@frebib.net>
This is a builtin alias for the same thing.

Signed-off-by: Joe Groocock <me@frebib.net>
@frebib frebib requested a review from a team as a code owner October 5, 2024 15:57
@frebib frebib requested review from jmartinesp and removed request for a team October 5, 2024 15:57
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (4319a42) to head (0b67dfd).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3611      +/-   ##
===========================================
- Coverage    82.67%   82.66%   -0.02%     
===========================================
  Files         1737     1737              
  Lines        41214    41214              
  Branches      5003     5003              
===========================================
- Hits         34073    34068       -5     
- Misses        5372     5373       +1     
- Partials      1769     1773       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch, thanks!

@bmarty bmarty merged commit b211941 into element-hq:develop Oct 7, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants