Add the CallWebView logs to our logging stack

[jmartinesp]

Content

Intercept the logs for the Element Call webview and log them using Timber so they go through our logging system.

Motivation and context

Element Call logs were lost in nightly and release versions of the app since they're not printed to the logcat or saved to disk, so it's very difficult to debug issues unless it's in a debug version.

Tests

• Open a call using EXA.
• Check the logcat, send a rageshake or check the logs using the bug report file viewer.
• Check there are [WebView] prefixed logs inside.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/uoiNoA

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (7a45024) to head (2f2d851).
Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
...nt/android/features/call/impl/ui/CallScreenView.kt	0.00%	14 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3637      +/-   ##
===========================================
- Coverage    82.77%   82.74%   -0.03%     
===========================================
  Files         1747     1747              
  Lines        41391    41405      +14     
  Branches      5015     5016       +1     
===========================================
  Hits         34260    34260              
- Misses        5358     5372      +14     
  Partials      1773     1773              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

Thanks, but are we sure that the log from the WebView will not contain any sensitive data?

[bmarty]

Could maybe have a better mapping using other provided fields:

override fun onConsoleMessage(consoleMessage: ConsoleMessage): Boolean {
    val priority = when (consoleMessage.messageLevel()) {
        ConsoleMessage.MessageLevel.ERROR -> Log.ERROR
        ConsoleMessage.MessageLevel.WARNING -> Log.WARN
        else -> Log.DEBUG
    }
    Timber.tag("[WebView]").log(
        priority = priority,
        message = buildString {
            append(consoleMessage.sourceId())
            append(":")
            append(consoleMessage.lineNumber())
            append(" ")
            append(consoleMessage.message())
        },
    )
    return true
}

[jmartinesp]

2f2d851

[jmartinesp]

Thanks, but are we sure that the log from the WebView will not contain any sensitive data?

According to @toger5 they don't contain sensitive data, the only thing that could be considered 'sensitive' are user ids, but that should be fine to log.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud