Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to launch a coroutine here. #3668

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 14, 2024

Small cleanup.
(Was originally in #3645)

@bmarty bmarty added the PR-Misc For other changes label Oct 14, 2024
@bmarty bmarty requested a review from a team as a code owner October 14, 2024 10:05
@bmarty bmarty requested review from jmartinesp and removed request for a team October 14, 2024 10:05
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/UAZHSb

Copy link

sonarcloud bot commented Oct 14, 2024

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.81%. Comparing base (01fb066) to head (212e576).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3668   +/-   ##
========================================
  Coverage    82.81%   82.81%           
========================================
  Files         1747     1747           
  Lines        41779    41781    +2     
  Branches      5107     5108    +1     
========================================
+ Hits         34598    34600    +2     
  Misses        5365     5365           
  Partials      1816     1816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 15, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 15, 2024
@bmarty bmarty merged commit bfc1b88 into develop Oct 15, 2024
32 of 34 checks passed
@bmarty bmarty deleted the feature/bma/noNeedForLaunch branch October 15, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants