Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated code regarding user (room member and user profile) screens #3700

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Remove duplicated code regarding user (room member and user profile) screens #3700

merged 8 commits into from
Oct 18, 2024

Commits on Oct 17, 2024

  1. Rework: use @AssistedFactory and comment out the UserProfileModule.

    @bmarty
    bmarty committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    77e874b View commit details
    Browse the repository at this point in the history

  2. Let RoomMemberDetailsPresenter use UserProfilePresenter to reduce cod… 

    …e duplication.
    @bmarty
    bmarty committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    95a7cf6 View commit details
    Browse the repository at this point in the history

  3. No need for UserProfilePresenterHelper anymore.

    @bmarty
    bmarty committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    86cfaf7 View commit details
    Browse the repository at this point in the history

  4. Format

    @bmarty
    bmarty committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9b9255d View commit details
    Browse the repository at this point in the history

  5. Renaming.

    @bmarty
    bmarty committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c5b0581 View commit details
    Browse the repository at this point in the history

  6. Cover getCanCall with tests.

    @bmarty
    bmarty committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e46503a View commit details
    Browse the repository at this point in the history

  7. Use test extension on presenter.

    @bmarty
    bmarty committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5a3b4df View commit details
    Browse the repository at this point in the history

  8. Reorder imports.

    @bmarty
    bmarty committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6106d7b View commit details
    Browse the repository at this point in the history