Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXI still intercepts EC links on macOS, and DoSes the OS #1824

Closed
ara4n opened this issue Sep 28, 2023 · 2 comments
Closed

EXI still intercepts EC links on macOS, and DoSes the OS #1824

ara4n opened this issue Sep 28, 2023 · 2 comments
Assignees
@stefanceriu
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Sep 28, 2023

Steps to reproduce

  1. Install EX Nightly and EX TF on macOS
  2. Click on an Element Call link in Apple Calendar or similar
  3. Watch as both apps go berserk fighting over the URL, flickering back and forth between them at 120fps, chewing 10 cores of CPU, and locking you out of using the machine as mouse & keyboard focus is constantly stolen by the window manager.
  4. The only way to get out is to stab frantically at Cmd-Q and hope to break the loop by quitting both apps adjacently.

This is 100% reproducable.

Outcome

What did you expect?

Not to get DoSed out of my laptop

What happened instead?

Two EXes went mad and colluded to steal my CPU and input devices

Your phone model

macOS 13.6 (22G120)

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@ara4n ara4n added the T-Defect label Sep 28, 2023
@ara4n
Copy link
Member Author

ara4n commented Sep 28, 2023

looks like the fix to #1794 didn't work

stefanceriu added a commit to element-hq/element-call that referenced this issue Sep 29, 2023
@stefanceriu
element-hq/element-x-ios/issues/1824 - Switch apple-app-site-associat…
710d08a 
…ions to the new format, add a query param exclusion for ignoring universal links
@stefanceriu
Copy link
Member

I tried getting the system to stop tightlooping between multiple apps that support the same universal links but I didn't get anyhwere. The new plan is this:

  1. Deploy this to call.element.io
  2. Have the universal link open one app as normal
  3. If the app can't handle the url (i.e. it's running on the mac) then add that extra no_universal_links query param and send it back to the system
  4. The system should now ignore the universal link and just open the browswer

stefanceriu added a commit to element-hq/element-call that referenced this issue Sep 29, 2023
@stefanceriu
element-hq/element-x-ios/issues/1824 - Switch apple-app-site-associat…
399ec9f 
…ions to the new format, add a query param exclusion for ignoring universal links
This was referenced Sep 29, 2023
Merged
Closed
@stefanceriu stefanceriu added S-Critical Prevents work, causes data loss and/or has no workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 4, 2023
@stefanceriu stefanceriu self-assigned this Oct 4, 2023
stefanceriu added a commit that referenced this issue Oct 5, 2023
@stefanceriu
Fixex #1824 - Redirect universal links directly to the browser if the…
b1ed681 
…y're not supported
stefanceriu added a commit that referenced this issue Oct 5, 2023
@stefanceriu
Fixes #1824 - Redirect universal links directly to the browser if the…
2bc624f 
…y're not supported
This was referenced Oct 5, 2023
Merged
Merged
stefanceriu added a commit to stefanceriu/element-web that referenced this issue Oct 5, 2023
@stefanceriu
element-hq/element-x-ios/issues/1824 - Convert the apple-app-site-ass…
2cde28e 
…ociation file to a newer format and introduce an option to opt out of universal links; reformat json.
germain-gg pushed a commit to element-hq/element-web that referenced this issue Oct 5, 2023
@stefanceriu
element-hq/element-x-ios/issues/1824 - Convert the apple-app-site-ass…
22f2b1f 
…ociation file to a newer format… (#26307)
@lucas-dclrcq lucas-dclrcq mentioned this issue Oct 24, 2023
Merged
1 task
This was referenced Oct 24, 2023
Open
Closed
Closed
Merged
Merged
Merged
Merged
Closed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Nov 4, 2023
@Midar
Update chat/element-web to 1.11.47
727a4ec 
Changes in [1.11.47](https://github.com/vector-im/element-web/releases/tag/v1.11.47) (2023-10-24)
=================================================================================================

## 🦖 Deprecations
 * Deprecate customisations in favour of Module API ([\#25736](element-hq/element-web#25736)). Fixes #25733.

## ✨ Features
 * element-hq/element-x-ios/issues/1824 - Convert the apple-app-site-association file to a newer format… ([\#26307](element-hq/element-web#26307)). Contributed by @stefanceriu.
 * Iterate `io.element.late_event` decoration ([\#11760](matrix-org/matrix-react-sdk#11760)). Fixes #26384.
 * Render timeline separator for late event groups ([\#11739](matrix-org/matrix-react-sdk#11739)).
 * OIDC: revoke tokens on logout ([\#11718](matrix-org/matrix-react-sdk#11718)). Fixes #25394. Contributed by @kerryarchibald.
 * Show `io.element.late_event` in MessageTimestamp when known ([\#11733](matrix-org/matrix-react-sdk#11733)).
 * Show all labs flags if developerMode enabled ([\#11746](matrix-org/matrix-react-sdk#11746)). Fixes #24571 and #8498.
 * Use Compound tooltips on MessageTimestamp to improve UX of date time discovery ([\#11732](matrix-org/matrix-react-sdk#11732)). Fixes #25913.
 * Consolidate 4s passphrase input fields and use stable IDs ([\#11743](matrix-org/matrix-react-sdk#11743)). Fixes #26228.
 * Disable upgraderoom command without developer mode enabled ([\#11744](matrix-org/matrix-react-sdk#11744)). Fixes #17620.
 * Avoid rendering app download buttons if disabled in config ([\#11741](matrix-org/matrix-react-sdk#11741)). Fixes #26309.
 * OIDC: refresh tokens ([\#11699](matrix-org/matrix-react-sdk#11699)). Fixes #25839. Contributed by @kerryarchibald.
 * OIDC: register ([\#11727](matrix-org/matrix-react-sdk#11727)). Fixes #25393. Contributed by @kerryarchibald.
 * Use stable get_login_token and remove unstable MSC3882 support ([\#11001](matrix-org/matrix-react-sdk#11001)). Contributed by @hughns.

## 🐛 Bug Fixes
 * Set max size for Element logo in search warning ([\#11779](matrix-org/matrix-react-sdk#11779)). Fixes #26408.
 * Avoid error when DMing oneself ([\#11754](matrix-org/matrix-react-sdk#11754)). Fixes #7242.
 * Fix: Message shield alignment is not right. ([\#11703](matrix-org/matrix-react-sdk#11703)). Fixes #26142. Contributed by @manancodes.
 * fix logging full event ([\#11755](matrix-org/matrix-react-sdk#11755)). Fixes #26376.
 * OIDC: use delegated auth account URL from `OidcClientStore` ([\#11723](matrix-org/matrix-react-sdk#11723)). Fixes #26305. Contributed by @kerryarchibald.
 * Fix: Members list shield alignment is not right. ([\#11700](matrix-org/matrix-react-sdk#11700)). Fixes #26261. Contributed by @manancodes.
 * Fix: <detail> HTML elements clickable area too wide. ([\#11666](matrix-org/matrix-react-sdk#11666)). Fixes #25454. Contributed by @manancodes.
 * Fix untranslated headings in the devtools dialog ([\#11734](matrix-org/matrix-react-sdk#11734)).
 * Fixes invite dialog alignment and pill color contrast ([\#11722](matrix-org/matrix-react-sdk#11722)). Contributed by @gabrc52.
 * Prevent select element in General settings overflowing in a room with very long room-id ([\#11597](matrix-org/matrix-react-sdk#11597)). Contributed by @ABHIXIT2.
 * Fix: Clicking on members pile does nothing. ([\#11657](matrix-org/matrix-react-sdk#11657)). Fixes #26164. Contributed by @manancodes.
 * Fix: Wierd shadow below room avatar in dark mode. ([\#11678](matrix-org/matrix-react-sdk#11678)). Fixes #26153. Contributed by @manancodes.
 * Fix start_sso / start_cas URLs failing to redirect to a authentication prompt ([\#11681](matrix-org/matrix-react-sdk#11681)). Contributed by @Half-Shot.

Changes in [1.11.46](https://github.com/vector-im/element-web/releases/tag/v1.11.46) (2023-10-10)
=================================================================================================

## ✨ Features
 * Use .well-known to discover a default rendezvous server for use with Sign in with QR ([\#11655](matrix-org/matrix-react-sdk#11655)). Contributed by @hughns.
 * Message layout will update according to the selected style  ([\#10170](matrix-org/matrix-react-sdk#10170)). Fixes #21782. Contributed by @manancodes.
 * Implement MSC4039: Add an MSC for a new Widget API action to upload files into the media repository ([\#11311](matrix-org/matrix-react-sdk#11311)). Contributed by @dhenneke.
 * Render space pills with square corners to match new avatar ([\#11632](matrix-org/matrix-react-sdk#11632)). Fixes #26056.
 * Linkify room topic ([\#11631](matrix-org/matrix-react-sdk#11631)). Fixes #26185.
 * Show knock rooms in the list ([\#11573](matrix-org/matrix-react-sdk#11573)). Contributed by @maheichyk.

## 🐛 Bug Fixes
 * Bump matrix-web-i18n dependency to 3.1.3 ([\#26287](element-hq/element-web#26287))
 * Fix: Avatar shrinks with long names ([\#11698](matrix-org/matrix-react-sdk#11698)). Fixes #26252. Contributed by @manancodes.
 * Update custom translations to support nested fields in structured JSON ([\#11685](matrix-org/matrix-react-sdk#11685)).
 * Fix: Edited message remove button is hard to reach. ([\#11674](matrix-org/matrix-react-sdk#11674)). Fixes #24917. Contributed by @manancodes.
 * Fix: Theme selector radio button not aligned in center with the text ([\#11676](matrix-org/matrix-react-sdk#11676)). Fixes #25460. Contributed by @manancodes.
 * Fix: Unread notification dot aligned ([\#11658](matrix-org/matrix-react-sdk#11658)). Fixes #25285. Contributed by @manancodes.
 * Fix: sync intentional mentions push rules with legacy rules ([\#11667](matrix-org/matrix-react-sdk#11667)). Fixes #26227. Contributed by @kerryarchibald.
 * Revert "Fix regression around FacePile with overflow (#11527)" ([\#11634](matrix-org/matrix-react-sdk#11634)). Fixes #26209.
 * Fix: Alignment Fixed ([\#11648](matrix-org/matrix-react-sdk#11648)). Fixes #26169. Contributed by @manancodes.
 * Fix: onFinished added which closes the menu ([\#11647](matrix-org/matrix-react-sdk#11647)). Fixes #25556. Contributed by @manancodes.
 * Don't start key backups when opening settings ([\#11640](matrix-org/matrix-react-sdk#11640)).
 * Fix add to space avatar text centering ([\#11643](matrix-org/matrix-react-sdk#11643)). Fixes #26154.
 * fix avatar styling in lightbox ([\#11641](matrix-org/matrix-react-sdk#11641)). Fixes #26196.
This was referenced Nov 7, 2023
Closed
Closed
@renovate renovate bot mentioned this issue Nov 21, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanceriu @ara4n