Fix garbled replies to replies due to invalid reply formatting #1202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to invalid formatting, replies to replies became garbled, causing display issues in some clients. Hydrogen itself managed
to display the replies correctly but other clients and bridges struggled because they were actually using the fallbacks.
The PR fixes the formatting of reply fallbacks (current spec: https://spec.matrix.org/v1.12/client-server-api/#fallbacks-for-rich-replies) and "mentions" the replied-to user when replying to a message as per https://spec.matrix.org/v1.12/client-server-api/#mentioning-the-replied-to-user.
In the examples below, I used a compliant client to send "first message", and to sent "second message" as a reply to "first message". I then sent "Hydrogen message" using Hydrogen as a reply to "second message".
Old, invalid formatting of reply fallbacks:
New, correct formatting of reply fallbacks:
Reply fallbacks are actively being removed in the upcoming spec but that doesn't mean that Hydrogen should keep the old bugged code in place.
MSCs for the upcoming spec: