-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Copy matrix.to
permalink" message action
#921
Conversation
|
||
// Copies the given text to clipboard and returns a boolean of whether the action was | ||
// successful | ||
export async function copyPlaintext(text: string): Promise<boolean> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on copy text utility from matrix-react-sdk
, see https://github.com/matrix-org/matrix-react-sdk/blob/ee13e23b156fbad9369d6a656c827b6444343d4f/src/utils/strings.ts#L25-L56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from exposing copyPlaintext through platform, lgtm. Thanks!
matrix.to
permalink" message action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, lgtm!
Thanks for the review and merge @bwindels 👽 |
Of note: - Adds date headers, element-hq/hydrogen-web#938 - Add "Copy matrix.to permalink" message action, element-hq/hydrogen-web#921 - Removes `?v=3.13` query parameters from Inter font references in CSS, element-hq/hydrogen-web#961 - This is what we need to solve #187 (comment)
Add "Copy
matrix.to
permalink" message actionPart of matrix-org/matrix-viewer#2