Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Copy matrix.to permalink" message action #921

Merged
merged 7 commits into from
Apr 11, 2023

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Nov 11, 2022

Add "Copy matrix.to permalink" message action


Part of matrix-org/matrix-viewer#2

@MadLittleMods MadLittleMods added the feature New feature or request label Nov 11, 2022

// Copies the given text to clipboard and returns a boolean of whether the action was
// successful
export async function copyPlaintext(text: string): Promise<boolean> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MadLittleMods MadLittleMods marked this pull request as ready for review November 11, 2022 02:57
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from exposing copyPlaintext through platform, lgtm. Thanks!

src/matrix/room/PowerLevels.js Outdated Show resolved Hide resolved
src/domain/session/room/timeline/tiles/BaseMessageTile.js Outdated Show resolved Hide resolved
@MadLittleMods MadLittleMods changed the title Add "Copy permalink" message action Add "Copy matrix.to permalink" message action Mar 27, 2023
@MadLittleMods MadLittleMods requested a review from bwindels March 27, 2023 20:50
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm!

@bwindels bwindels merged commit a8d4928 into master Apr 11, 2023
@MadLittleMods
Copy link
Contributor Author

Thanks for the review and merge @bwindels 👽

MadLittleMods added a commit to matrix-org/matrix-viewer that referenced this pull request Apr 26, 2023
Of note:

 - Adds date headers, element-hq/hydrogen-web#938
 - Add "Copy matrix.to permalink" message action, element-hq/hydrogen-web#921
 - Removes `?v=3.13` query parameters from Inter font references in CSS, element-hq/hydrogen-web#961
    - This is what we need to solve #187 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants